Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Andrea Valliere - Trek #24

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Conversation

avalliere
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Different parts of the code are running at different times, largely depending on user-prompted actions.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? My post request for reserving a spot on a trip needed to happen within the callback with trip details. I originally had it outside of this callback and it did not ever hit my function for the post.
What kind of errors might the API give you? How did you choose to handle them? My failure callback displays a message when something goes wrong.
What is an Underscore template? Describe one template you used for this project. An Underscore template neatly renders html that's been generated by javascript. One of the templates I used in this project takes the json data for all trips (which has been retrieved from the API through javascript) and renders the data into a list.
Do you have any recommendations on how we could improve this project for the next cohort? None at this time. This has been one of my favorite projects.

avalliere added 28 commits May 23, 2017 15:47
…tails after other trip details have been hidden
@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes - I'm glad you enjoyed it!
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot yes
Errors are reported to the user yes
Styling, Foundation grid layout yes - wonderful look and feel
Under the Hood
Trip data is retrieved using jQuery AJAX yes
JavaScript is well-organized and easy to read yes
HTML is semantic some - there are a few places you use <div> tags where a <section> or <aside> might be more meaningful
All dynamic content is rendered using Underscore templates yes - good work only compiling your templates once
Overall

I'm quite happy with the code you've submitted - keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants