Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queues - Elizabeth Deutsch - Trek #26

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Queues - Elizabeth Deutsch - Trek #26

wants to merge 8 commits into from

Conversation

edeutschie
Copy link

@edeutschie edeutschie commented May 30, 2017 •
edited
Loading

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that the code is written is such a way that the user can continue to interact with a web page while a request is in the midst of being fulfilled. Multiple things can be happening at once.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? The code that displays the individual trip info is present but does not run until a user clicks the "More Info" button for a particular trip. When they do, I want the info to be displayed at the top of the web page. So, I put the anchor code for that div at the top of the index.html doc. That way, the code is sitting there waiting to be activated while the rest of the HTML (which is written below it) is loaded into the browser. The HTML code is rendered out of order and asynchronously in terms of the order it is written in index.html.
What kind of errors might the API give you? How did you choose to handle them? The request for all the trips may not go through (I had the error message result be 404 Not Found, "API request failed!" to be printed in the browser, and "Didn't work" to be printed to the console log), a request for one trip may not go through (I had the error message result be 404 Not Found, "API request failed!" to be printed in the browser, and "Didn't work" to be printed to the console log), a reservation may not be processed by the API (I had "Reservation Did Not Go Through" printed in the browser.
What is an Underscore template? Describe one template you used for this project. Underscore is like ERB in rails. Underscore templates allow us to generate complex HTML structures by embedding code in the document. A template only needs to be compiled once to generate HTML code many times so it saves time and keeps your code DRYer. I used and underscore template to generate and display the trip info for each individual trip.
Do you have any recommendations on how we could improve this project for the next cohort? There was some confusion around what was required for each Wave, but I think you are already working on clarifying that for Cohort 8. Once I knew what was required for each Wave, I really appreciated the amount of time allotted to complete the project.

@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot yes
Errors are reported to the user yes
Styling, Foundation grid layout yes
Under the Hood
Trip data is retrieved using jQuery AJAX yes
JavaScript is well-organized and easy to read mostly - your function names could be a little more clear. For example, successCallback and successCallbackTrek could be listTripsCallback and tripDetailsCallback
HTML is semantic yes, though it's a little odd to me that your template scripts are mixed in with your static HTML. Typically templates are placed at the very end of the <body> tag.
All dynamic content is rendered using Underscore templates yes
Overall

I'm quite happy with the code you've submitted - keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edeutschie @droberts-sea