Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Hyunji Kim - trek #27

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ricecakemonster
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? an operation starts without waiting for another operation to be finished.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? All the on("click"...) codes are asynchronous.
What kind of errors might the API give you? How did you choose to handle them? success: execute the function, fail: shows error messages.
What is an Underscore template? Describe one template you used for this project. It's like partials in raiils app. You can use templates to show different views instead of refreshing or redirecting pages. displaying all the trips.
Do you have any recommendations on how we could improve this project for the next cohort?

@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot yes
Errors are reported to the user no - you have some jQuery code to put an error message on the page, but it the element it targets doesn't exist so nothing appears
Styling, Foundation grid layout yes - good work
Under the Hood
Trip data is retrieved using jQuery AJAX yes
JavaScript is well-organized and easy to read yes
HTML is semantic yes
All dynamic content is rendered using Underscore templates yes
Overall

Great work on the optionals! I'm quite happy with the code you've submitted - keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants