Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ashtons Trek #31

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Ashtons Trek #31

wants to merge 7 commits into from

Conversation

ashtn
Copy link

@ashtn ashtn commented May 30, 2017

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? it means that code may not run top down, line by line, but is often waiting for a trigger from a user, like a click on a button.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Index Click Handler, is a piece of code that executes asynchronously, when a button is pressed it performs an action of putting together the url and making a call to the api, it then waits for a response and calls another function based on the response (success or failure) that will execute it's own set of code.
What kind of errors might the API give you? How did you choose to handle them? Some errors you may encounter include Bad Url, Trip Id does not exist, etc. I chose to handle errors in my failure callback function by displaying a message on the screen.
What is an Underscore template? Describe one template you used for this project. Underscore template is a script we use to dynamically generate HTML content via jquery. A template I used for this project was a trip index, that displayed a list of trips, that were clickable through to their associated trip details.
Do you have any recommendations on how we could improve this project for the next cohort?

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Probably could do more granular commits, but it's a small project.
Comprehension questions Check
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check, I like how the form disappears when you submit, that way you can't double-book!
Errors are reported to the user It reports something went wrong.
Styling, Foundation grid layout Some small issues with the fixed height in the footer being smaller than the contents so the white shows at the bottom especially with a mobile device. It is responsive, which is nice.
Under the Hood
Trip data is retrieved using jQuery AJAX Check
JavaScript is well-organized and easy to read Check, I like how the comments separated out.
HTML is semantic Check, again good comments to separate content.
All dynamic content is rendered using Underscore templates Check
Overall Nicely done. The code is well organized, I can see where you had some frustrations with styling, but you're meeting all requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants