Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queues - Cynthia Cob - Trek #40

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Conversation

cynthiacd
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Synchronous code runs top down - meaning each line of code is run to completion before moving to the next line. JS is asynchronous meaning code that some code can be scheduled to run in the future - Example: if a section of code is going to take some time, code below that line will be ran
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? For my click handler functions I had to use the on function (instead of the click function) - because I automatically include an api request to get all trips when the page loads.
What kind of errors might the API give you? How did you choose to handle them? The API might time out or have a 500 error and not respond with the wanted info - if this happens, a message appears to the user letting them know something has gone wrong and to try again later
What is an Underscore template? Describe one template you used for this project. Underscore lets us generate HTML with JS. I used one template to show all the trip information (part of the form is hidden until the user request more information about that trip)
Do you have any recommendations on how we could improve this project for the next cohort? Go over more examples with js-selectors. I ended up using lots of id to make sure I was only accessing a single trip element, but I know there are other ways to use scope to access elements

@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot yes
Errors are reported to the user yes - good work!
Styling, Foundation grid layout yes
Under the Hood
Trip data is retrieved using jQuery AJAX yes
JavaScript is well-organized and easy to read yes - good use of comments to delineate sections
HTML is semantic yes
All dynamic content is rendered using Underscore templates yes
Overall

I'm quite happy with the code you've submitted - keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants