Skip to content

Commit

Permalink
add comprehension q on what if there were multiple apis, add explicit…
Browse files Browse the repository at this point in the history
… error handling req on bad recipe detail URL
  • Loading branch information
tildeee committed Oct 30, 2018
1 parent 9585fb4 commit ac1c452
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Congratulations! You're submitting your assignment!
Question | Answer
:------------- | :-------------
How did you go about exploring the Edamam API, and how did you try querying the API? |
What is an API Wrapper? Why is it in `lib`? |
What is an API Wrapper? Why is it in `lib`? How would your project change if you needed to interact with more than one API (aka more than just the Edamam API)? |
Describe your API wrapper, the methods you created in it, and why you decided to create those methods/how they were helpful |
What was an edge case or failure case test you wrote for your API Wrapper? What was a nominal case? |
How does VCR aid in testing an API? |
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ Once you've explored the API docs, this project:
- Ingredients
- Dietary information

### Miscellaneous Requirements
### Non-functional Requirements

- Follow the requirements of attribution to Edamam, as required by their Terms and Conditions
- [Official documentation from Edamam on attribution](https://developer.edamam.com/attribution)
- Create thorough tests for your any API Wrappers, classes, and controllers using VCR
- Use semantic HTML
- As a user, when I interact with the site and there is a problem, then I can see an error message detailing what the problem is and what I should do
- As a user, when I put in an incorrect parameter for an individual recipe in the browser's address bar, then the site reports a friendly error explaining that this recipe doesn't exist, and doesn't show an exception

## Important Notes

Expand Down

0 comments on commit ac1c452

Please sign in to comment.