Rock - Libby #38
Open
Rock - Libby #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
May 29, 2021
| videos_checked_out_count = db.Column(db.Integer, nullable = False, default=0) | ||
| rentals_out = db.relationship("Rental", backref="customer") #is lazy=True needed? | ||
|
|
||
| def return_data(self): |
Comment on lines
+3
to
+4
| from datetime import datetime | ||
| from app.models.rental import Rental |
There was a problem hiding this comment.
even though we mention "Rental" as a string argument, we aren't using the class itself or creating instances, so we don't need this
Suggested change
| from datetime import datetime | |
| from app.models.rental import Rental | |
| from datetime import datetime |
| @@ -0,0 +1,26 @@ | |||
| # from flask import current_app | |||
| from app import db | |||
| from app.models.rental import Rental | |||
There was a problem hiding this comment.
Suggested change
| from app.models.rental import Rental |
| rentals_out = db.relationship("Rental", backref="video") #is lazy=True needed? | ||
|
|
||
|
|
||
| def return_data(self): |
| from app.models.video import Video | ||
| from app.models.rental import Rental | ||
| from app import db | ||
| import requests |
|
|
||
| @customers_bp.route("/<customer_id>", methods=["GET"], strict_slashes=False) | ||
| def get_one_customer(customer_id): | ||
| customer = Customer.query.get_or_404(customer_id) |
Comment on lines
+57
to
+61
| response.append( | ||
| {"release_date": video.release_date, | ||
| "title": video.title, | ||
| "due_date":rental.due_date | ||
| }) |
There was a problem hiding this comment.
maybe we could turn this into a helper method in our model liked the others you made!
| def update_customer(customer_id): | ||
| customer = Customer.query.get_or_404(customer_id) | ||
| request_body = request.get_json() | ||
| print(f"request body: {request_body}") |
There was a problem hiding this comment.
oop! don't forget to remove print statements used for debugging/troubleshooting
Comment on lines
+70
to
+78
| if "name" not in request_body \ | ||
| or "postal_code" not in request_body \ | ||
| or "phone" not in request_body: | ||
| return make_response({}, 400) | ||
|
|
||
| elif type(request_body["name"]) is not str or request_body["name"] == "" \ | ||
| or type(request_body["phone"]) is not str or request_body["phone"] == "" \ | ||
| or type(request_body["postal_code"]) is not int or request_body["postal_code"] == "": | ||
| return make_response({}, 400) |
There was a problem hiding this comment.
since these have the same return statement, maybe we can combine the two conditionals and they can share the same return statement
Comment on lines
+211
to
+217
| response = { | ||
| "customer_id": new_rental.customer_id, | ||
| "video_id": new_rental.video_id, | ||
| "due_date": new_rental.due_date, | ||
| "videos_checked_out_count": customer.videos_checked_out_count, | ||
| "available_inventory": video.available_inventory | ||
| } |
There was a problem hiding this comment.
another good place for a helper method!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.