Paper - Kaylyn Cardella #63
Conversation
and video.py and defines respective models. .env created with development and test database URI.
Updates database to reflect attribute changes to customer.py & video.py
Rental.py populated with model Rental with many-to-many relationship established
…s_by_customer_id. Updates customer.py with relationship to Rental.
| postal_code = db.Column(db.Integer) | ||
| phone = db.Column(db.String) | ||
| registered_at = db.Column(db.DateTime, default=datetime.utcnow()) | ||
| videos_checked_out_count = db.Column(db.Integer, default=0) |
There was a problem hiding this comment.
Instead of this being a column you can use the rentals to count that.
To do that it's helpful to add a relationship:
| videos_checked_out_count = db.Column(db.Integer, default=0) | |
| rentals = db.relationship('Rental', back_populates='customer', lazy=True) |
| "postal_code": self.postal_code, | ||
| "phone": self.phone, | ||
| "registered_at": self.registered_at, | ||
| "videos_checked_out_count": self.videos_checked_out_count |
There was a problem hiding this comment.
Once you have the relationship the videos_checked_out_count is just the length of the rentals that haven't been checked in:
| "videos_checked_out_count": self.videos_checked_out_count | |
| "videos_checked_out_count": len([rental for rental in self.rentals if not rental.check_in_date]) |
| video_id = db.Column(db.Integer, db.ForeignKey("videos.video_id")) | ||
| customers = db.relationship("Customer", backref="rentals") | ||
| videos = db.relationship("Video", backref="rentals") | ||
|
|
There was a problem hiding this comment.
You may want to add a check in date to know if the user returned this rental:
| check_in_date = db.Column(db.DateTime, nullable=True) |
| title = db.Column(db.String) | ||
| release_date = db.Column(db.DateTime) | ||
| total_inventory = db.Column(db.Integer) | ||
| available_inventory = db.Column(db.Integer) |
There was a problem hiding this comment.
Like with Customer you can compute available_inventory with a relationship:
| available_inventory = db.Column(db.Integer) | |
| rentals = db.relationship('Rental', back_populates='video', lazy=True) |
| "title": self.title, | ||
| "release_date": self.release_date, | ||
| "total_inventory": self.total_inventory, | ||
| "available_inventory": self.available_inventory |
There was a problem hiding this comment.
Like with Customer the available_inventory is just the total inventory minus length of the rentals that haven't been checked in:
| "available_inventory": self.available_inventory | |
| "available_inventory": self.total_inventory - len([rental for rental in self.rentals if not rental.check_in_date]) |
|
|
||
| @customers_bp.route("/<customer_id>", methods=["GET"], strict_slashes=False) | ||
| def get_customer_by_id(customer_id): | ||
| customer = Customer.query.get_or_404(customer_id) |
There was a problem hiding this comment.
Good use of get_or_404!
| customer = Customer.query.get(int(rental.customer_id)) | ||
| video = Video.query.get(int(rental.video_id)) |
There was a problem hiding this comment.
You probably want to just get_or_404 these before trying to make the rental.
| video.available_inventory -= 1 | ||
| customer.videos_checked_out_count += 1 |
There was a problem hiding this comment.
If you compute the available_inventory and videos_checked_out_count from the rentals then you don't have to worry about managing these fields and they can't get out of sync.
| rentals = Rental.query.filter_by(customer_id=customer_id).all() | ||
|
|
||
| rentals_response = [] | ||
|
|
||
| for rental in rentals: |
There was a problem hiding this comment.
| rentals = Rental.query.filter_by(customer_id=customer_id).all() | |
| rentals_response = [] | |
| for rental in rentals: | |
| rentals_response = [] | |
| for rental in customer.rentals: |
No description provided.