-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C22 - Phoenix - Charday N. #73
Open
chardayneal
wants to merge
14
commits into
AdaGold:main
Choose a base branch
from
chardayneal:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete initial setup of project, including migrations directory being using for Task Model changes. Create tasks endpoint for creating, reading, updating and deleting. Enable few tests from Wave 01
Create helper function to ensure task is created with proper details. Handle appropriately should we receive request with invalid details for new task.
Implement sorting feature by adding sort query param that sorts tasks by title, ascending and descending
Created validate_model and create_model helper methods to DRY up code and create reusable functions Created an endpoint that marks tasks complete and incomplete Updated task model only to revert changes to resolve issue.
Updated the goal model attributes with 'title' and migrated changes Create GET, POST, PUT, DELETE endpoints for Goal model Completed partial testing for endpoints
Implemented some asserts to a few tests to ensure our api responds appropriately to an invalid request and that exception are in fact raised.
Tests invalid requests made by user and ensure they're handle appropriately
Create a one-to-many relationship with Goal and Task models Create endpoints that allow users to view tasks by goal and add task ids to a specified goal
Refactor code to ensure consistency throughout app Refactor Goal models methods to_dict() and from_dict()
Code used legacy code and updated with session.get() preferred method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.