Skip to content

Cm/wave 1 controller tests #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cm/wave 1 controller tests #20

wants to merge 2 commits into from

Conversation

CheezItMan
Copy link
Contributor

I've added wave 1 controller tests in an effort to make the project more manageable.

Let me know what you think, should we merge this in and reduce the scope of the project?

jmaddox19
jmaddox19 reviewed Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jmaddox19 jmaddox19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Chris! LGTM!

Did you mean to submit this PR against Ada-C14 rather than AdaGold?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jmaddox19 jmaddox19 jmaddox19 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CheezItMan @jmaddox19