Skip to content

Commit

Permalink
Added conditional copilation for the configureation parameters.
Browse files Browse the repository at this point in the history
Updated RELEASE_NOTES. Tested on freebsd and umbuntu linux.
Reset AutoBuild.sh to use internal spf library.
  • Loading branch information
Bryan Costales authored and Murray S. Kucherawy committed Jul 16, 2014
1 parent 9bbe125 commit be425ed
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 3 deletions.
2 changes: 1 addition & 1 deletion AutoBuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ fi

autoreconf -v -i

CONF="./configure -q --with-wall -C --with-spf --with-spf2-include=/usr/local/include/spf2 --with-spf2-lib=/usr/local/lib/"
CONF="./configure -q --with-wall -C --with-spf"
echo ${CONF}
perform "$CONF"
perform "make -s"
Expand Down
1 change: 1 addition & 0 deletions RELEASE_NOTES
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ release, and a summary of the changes in that release.
1.3.0 2014/05/??
Add configuration support for internal SPF checks. Inlcudes hooks in
the milter to check that SPF is configured to do so.
This can use a private SPF impleemntation or libspf2.
Feature request #79: Optionally ignore clients that authenticated
using SMTP AUTH.
Fix bug #60, part II: Default AuthservID to the name provided by the
Expand Down
13 changes: 11 additions & 2 deletions opendmarc/opendmarc.c
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ struct dmarcf_config
_Bool conf_addswhdr;
_Bool conf_authservidwithjobid;
_Bool conf_recordall;
#if WITH_SPF
_Bool conf_spfignoreresults;
_Bool conf_spfselfvalidate;
_Bool conf_ignoreauthclients;
Expand Down Expand Up @@ -2260,7 +2261,11 @@ mlfi_eom(SMFICTX *ctx)
/* walk through what was found */
for (c = 0; c < ar.ares_count; c++)
{
if (ar.ares_result[c].result_method == ARES_METHOD_SPF)
if (ar.ares_result[c].result_method == ARES_METHOD_SPF
#if WITH_SPF
&& conf->conf_spfignoreresults == FALSE
#endif
)
{
int spfmode;

Expand Down Expand Up @@ -2413,7 +2418,11 @@ mlfi_eom(SMFICTX *ctx)
}
}

if (!wspf)
if (!wspf
#if WITH_SPF
&& conf->conf_spfignoreresults == FALSE
#endif
)
{
for (hdr = dfc->mctx_hqhead;
hdr != NULL && !wspf;
Expand Down
3 changes: 3 additions & 0 deletions opendmarc/opendmarc.conf.sample
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,9 @@
## SPFSelfValidate { true | false }
## default false
##
## Enable internal spf checking with --with-spf
## To use libspf2 instead: --with-spf --with-spf2-include=path --with-spf2-lib=path
##
## Causes the filter to perform a fallback SPF check itself when
## it can find no SPF results in the message header. If SPFIgnoreResults
## is also set, it never looks for SPF results in headers and
Expand Down

0 comments on commit be425ed

Please sign in to comment.