Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade orjson from 3.9.7 to 3.9.15 #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AdamOswald
Copy link
Owner

@AdamOswald AdamOswald commented Feb 27, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • requirements.txt
⚠️ Warning
transformers 4.30.2 has requirement tokenizers!=0.11.3,<0.14,>=0.11.1, but you have tokenizers 0.15.2.
torch 1.13.1 requires nvidia-cudnn-cu11, which is not installed.
torch 1.13.1 requires nvidia-cuda-nvrtc-cu11, which is not installed.
torch 1.13.1 requires nvidia-cublas-cu11, which is not installed.
torch 1.13.1 requires nvidia-cuda-runtime-cu11, which is not installed.
tensorflow-hub 0.16.1 requires tf-keras, which is not installed.
tensorboard 2.11.2 has requirement protobuf<4,>=3.9.2, but you have protobuf 4.24.4.
tensorboard 2.11.2 has requirement setuptools>=41.0.0, but you have setuptools 40.5.0.
scikit-learn 1.0.2 requires scipy, which is not installed.
python-igraph 0.11.4 has requirement igraph==0.11.4, but you have igraph 0.10.8.
powerlaw 1.5 requires scipy, which is not installed.
pipenv 2023.10.3 has requirement setuptools>=67, but you have setuptools 40.5.0.
paddlenlp 2.7.2 requires seqeval, which is not installed.
paddlenlp 2.7.2 has requirement dill<0.3.5, but you have dill 0.3.7.
paddlenlp 2.7.2 has requirement multiprocess<=0.70.12.2, but you have multiprocess 0.70.15.
paddle2onnx 0.9.5 has requirement onnx<=1.9.0, but you have onnx 1.14.1.
onnxruntime 1.14.1 has requirement numpy>=1.21.6, but you have numpy 1.21.3.
onnxruntime-gpu 1.14.1 has requirement numpy>=1.21.6, but you have numpy 1.21.3.
lpips 0.1.4 requires scipy, which is not installed.
gradio 3.34.0 requires orjson, which is not installed.
filterpy 1.4.5 requires scipy, which is not installed.
facexlib 0.3.0 requires scipy, which is not installed.
datasets 2.13.2 has requirement dill<0.3.7,>=0.3.0, but you have dill 0.3.7.
botocore 1.33.13 has requirement urllib3<1.27,>=1.25.4; python_version < "3.10", but you have urllib3 2.0.7.

Vulnerabilities that will be fixed

By pinning:
Severity Priority Score (*) Issue Upgrade Breaking Change Exploit Maturity
high severity 661/1000
Why? Recently disclosed, Has a fix available, CVSS 7.5
Relative Path Traversal
SNYK-PYTHON-ORJSON-6276643
orjson:
3.9.7 -> 3.9.15
No No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Relative Path Traversal

Summary by CodeRabbit

  • Chores
    • Updated dependencies to include orjson>=3.9.15 for enhanced security.

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-ORJSON-6276643
Copy link

Unable to locate .performanceTestingBot config file

Copy link

aviator-app bot commented Feb 27, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Micro-Learning Topic: Path traversal (Detected by phrase)

Matched on "Path Traversal"

What is this? (2min video)

Path traversal vulnerabilities occur when inputs that have not been sufficiently validated or sanitised are used to build directory or file paths. If an attacker can influence the path being accessed by the server, they may be able to gain unauthorised access to files or even execute arbitrary code on the server (when coupled with file upload functionality).

Try a challenge in Secure Code Warrior

Helpful references
  • OWASP Input Validation Cheat Sheet - This cheatsheet is focused on providing clear, simple, actionable guidance for preventing injection and input validation flaws in your applications, including defence against path traversal.
  • OWASP Path Traversal - OWASP community page with comprehensive information about path traversal, and links to various OWASP resources to help detect or prevent it.

This PR has 0 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : No Changes
Size       : +0 -0
Percentile : 0%

Total files changed: 1

Change summary by file extension:
.txt : +0 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Copy link

coderabbitai bot commented Feb 27, 2024

Walkthrough

This update introduces a single, yet crucial modification to the project's dependencies by adding orjson>=3.9.15 to the requirements.txt file. This action was taken to address a specific vulnerability, ensuring the project's security and reliability are maintained. The change highlights a proactive approach to dependency management and security practices within the project.

Changes

File Change Summary
requirements.txt Added orjson>=3.9.15 to address a vulnerability

🐇✨
In the garden of code, where the digital trees sway,
A rabbit hopped by, making changes today.
With a twirl and a tap, a new line was penned,
orjson now safe, on this rabbit depend.
For security's sake, with a vulnerability mended,
Our project leaps forward, with strength unpretended.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. All the files appear to be documentation files, which we're not great at reviewing... yet!

Copy link

difflens bot commented Feb 27, 2024

View changes in DiffLens

Copy link

Hi there! 👋 Thanks for opening a PR. 🎉 To get the most out of Senior Dev, please sign up in our Web App, connect your GitHub account, and add/join your organization AdamOswald. After that, you will receive code reviews beginning on your next opened PR. 🚀

Copy link

difflens bot commented Feb 27, 2024

View changes in DiffLens

Copy link

guide-bot bot commented Feb 27, 2024

Thanks for opening this Pull Request!
We need you to:

  1. Fill out the description.

    Action: Edit description and replace <!- ... --> with actual values.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0518dd3 and 53333f4.
Files selected for processing (1)
  • requirements.txt (1 hunks)
Additional comments: 1
requirements.txt (1)
  • 113-113: The addition of orjson>=3.9.15 is a necessary step to address the identified security vulnerability. However, given the PR's warnings about potential compatibility issues with other packages, it's crucial to ensure that this upgrade does not introduce conflicts with other dependencies, especially those that might also rely on orjson. It would be beneficial to perform a thorough dependency resolution test to confirm that all packages remain compatible after this upgrade. Additionally, considering the project's reliance on a wide range of packages, some of which are installed from external sources or specific versions, it's important to verify that the orjson upgrade does not inadvertently affect these installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants