Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accept headers on lambdaRest and formatResponse #193

Merged
merged 2 commits into from
Oct 3, 2023
Merged

feat: accept headers on lambdaRest and formatResponse #193

merged 2 commits into from
Oct 3, 2023

Conversation

gabrielforster
Copy link
Member

Description

Changing lambdaResp and formatResponse functions so they accept headers and return them to the final response.

closes #192

@gabrielforster gabrielforster added the enhancement New feature or request label Oct 3, 2023
@gabrielforster gabrielforster self-assigned this Oct 3, 2023
CauaKath
CauaKath approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@CauaKath CauaKath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcofeliponi
marcofeliponi approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@marcofeliponi marcofeliponi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caroltrindade
caroltrindade approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@caroltrindade caroltrindade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielforster gabrielforster merged commit 738de49 into develop Oct 3, 2023
@gabrielforster gabrielforster deleted the feat/accept-headers-on-lambda-rest-and-format-response branch October 3, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CauaKath CauaKath CauaKath approved these changes

@marcofeliponi marcofeliponi marcofeliponi approved these changes

@caroltrindade caroltrindade caroltrindade approved these changes

Assignees

@gabrielforster gabrielforster

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lambdaResp doesnt accept headers key as param.
4 participants
@gabrielforster @caroltrindade @marcofeliponi @CauaKath