Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-issue-594] Add new section to how-ad-blocking-works.md #613

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Conversation

vyanovsky
Copy link
Contributor

@vyanovsky vyanovsky commented Nov 25, 2024

Added a new section "Types of request handling in AdGuard" to how-ad-blocking-works.md, that explains those types (blocked, allowed, modified) with some examples. Source of this change is proposal from a user: #594

Added a new section "Types of request handling in AdGuard" to how-ad-blocking-works.md, that explains those types (blocked, allowed, modified) with some examples.
Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

2 similar comments
Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

1 similar comment
Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

docs/general/ad-filtering/how-ad-blocking-works.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/how-ad-blocking-works.md Outdated Show resolved Hide resolved

AdGuard Base filter allows non-ad requests such as `www.google.com/complete/search?q=`.

Filter unblocking search ads and self-promotion allows search ads requests, such as `www.google.com/aclk?`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search ads requests звучит непонятно — запросы от поисковой рекламы или к ней?
и лишняя запятая перед suсh as

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

подправил

docs/general/ad-filtering/how-ad-blocking-works.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/how-ad-blocking-works.md Outdated Show resolved Hide resolved
docs/general/ad-filtering/how-ad-blocking-works.md Outdated Show resolved Hide resolved
Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

Copy link

Preview was deployed to: https://pull-request-613.kb-adg.pages.dev/

@vyanovsky vyanovsky merged commit 6388ec2 into master Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants