[AG-37539] Added note to exception modifiers #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
105th
requested changes
Mar 3, 2025
| @@ -1080,6 +1080,21 @@ We recommend to get acquainted with [the Adblock Plus filter cheatsheet](https:/ | |||
|
|
|||
| ::: | |||
|
|
|||
| :::info | |||
|
|
|||
| Exception rule modifiers will disable other basic rules only for main frame document requests (see [`$document`](#document-modifier) for more information about main frame document). | |||
There was a problem hiding this comment.
maybe add something along the lines of "by default, without specifying additional content types"?
There was a problem hiding this comment.
otherwise it looks like it works only for main frame and there are no other ways
There was a problem hiding this comment.
Does "By default, without specifying additional content type modifiers exception rule modifiers will ..." sounds good?
|
Preview was deployed to: https://pull-request-652.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-652.kb-adg.pages.dev/ |
el-termikael
requested changes
Mar 3, 2025
Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-652.kb-adg.pages.dev/ |
el-termikael
approved these changes
Mar 4, 2025
maximtop
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.