This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
thumbnail configs #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edanaher
approved these changes
May 17, 2022
| "ENABLE_TEMPLATE_PROCESSING": True} | ||
| "ENABLE_TEMPLATE_PROCESSING": True, | ||
| "THUMBNAILS": True, | ||
| "THUMBNAIL_CACHE_CONFIG": CacheConfig = { "CACHE_TYPE": "null", "CACHE_NO_NULL_WARNING": True}} |
There was a problem hiding this comment.
We probably could cache these somewhere, but not knowing how it's used, I'm fine leaving the cache disabled unless we know it's causing issues.
|
That actually broke superset, so I pulled the cache part and will update
that again today. Just struggling to find the right language to make the
cache work, because without it we get empty thumbnails:
[image: Screen Shot 2022-05-17 at 9.07.13 AM.png]
…On Tue, May 17, 2022 at 8:05 AM Evan Danaher ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In superset_config.py
<#3 (comment)>:
> @@ -161,7 +161,9 @@ class CeleryConfig(object):
"DASHBOARD_NATIVE_FILTERS_SET": True,
"GENERIC_CHART_AXES": True,
"EMBEDDED_SUPERSET": True,
- "ENABLE_TEMPLATE_PROCESSING": True}
+ "ENABLE_TEMPLATE_PROCESSING": True,
+ "THUMBNAILS": True,
+ "THUMBNAIL_CACHE_CONFIG": CacheConfig = { "CACHE_TYPE": "null", "CACHE_NO_NULL_WARNING": True}}
We probably could cache these somewhere, but not knowing how it's used,
I'm fine leaving the cache disabled unless we know it's causing issues.
—
Reply to this email directly, view it on GitHub
<#3 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARWKOQRFG2GAHQPC56XL5YLVKODPTANCNFSM5WDPMIGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
JPHaus
reviewed
May 17, 2022
| "ENABLE_TEMPLATE_PROCESSING": True} | ||
| "ENABLE_TEMPLATE_PROCESSING": True, | ||
| "THUMBNAILS": True, | ||
| "THUMBNAIL_CACHE_CONFIG": CacheConfig = { "CACHE_TYPE": "null", "CACHE_NO_NULL_WARNING": True}} |
There was a problem hiding this comment.
@bethany-poulin any links to relevant documentation?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.