Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Java 21 #3214

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix build on Java 21 #3214

merged 2 commits into from
Jan 17, 2024

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Nov 16, 2023

Ignore test parsing "12:00 am" on JDK21 due to
https://bugs.openjdk.org/browse/JDK-8304925
Use always the fixed locale (instead of the platform default) for Variant date formats

This fixes #3213

@kwin kwin force-pushed the bugfix/fix-jdk21-build branch 2 times, most recently from 66ad28a to db052b3 Compare November 16, 2023 16:32
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6649768) 1.34% compared to head (e7665c3) 1.34%.

Files Patch % Lines
.../main/java/com/adobe/acs/commons/data/Variant.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master   #3214      +/-   ##
===========================================
- Coverage      1.34%   1.34%   -0.01%     
  Complexity       44      44              
===========================================
  Files           721     721              
  Lines         29537   29538       +1     
  Branches       3844    3844              
===========================================
  Hits            397     397              
- Misses        29124   29125       +1     
  Partials         16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kwin kwin added the Skip-Changelog Skips the check for a changelog entry in the CI build label Nov 17, 2023
@kwin
Copy link
Contributor Author

kwin commented Nov 22, 2023

@davidjgonzalez Any reason this is not included in 6.3.2?

Ignore test parsing "12:00 am" on JDK21 due to
https://bugs.openjdk.org/browse/JDK-8304925
Use always the fixed locale (instead of the platform default) for
Variant date formats

This fixes #3213
@kwin kwin force-pushed the bugfix/fix-jdk21-build branch from db052b3 to 8dc71fc Compare November 22, 2023 16:11
@kwin kwin merged commit 84e4a5f into master Jan 17, 2024
20 of 21 checks passed
@kwin kwin deleted the bugfix/fix-jdk21-build branch January 17, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog Skips the check for a changelog entry in the CI build technical enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This Project's Github Action JDK 21 builds fail
2 participants