Defect/mcp forms/npe on multifield #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3265 +/- ##
===========================================
+ Coverage 1.34% 1.78% +0.43%
- Complexity 44 100 +56
===========================================
Files 721 721
Lines 29527 29530 +3
Branches 3838 3840 +2
===========================================
+ Hits 397 526 +129
+ Misses 29114 28966 -148
- Partials 16 38 +22 ☔ View full report in Codecov by Sentry. |
csaboka
force-pushed
the
defect/mcp-forms/npe-on-multifield
branch
from
3c3f13e to
cfea1f7
Compare
|
Well, codeclimate is complaining about the license header, even though I used |
|
Look at #2500. |
|
Thank you. I'll keep things simple and change the copyright line to say Adobe. I agree it would be better if there was some clear indication about it, though. |
ValueMaps should never contain null values. They should not report a key as present if there is no corresponding value.
ValueMaps should never contain null values. They should not report a key as present if there is no corresponding value.
csaboka
force-pushed
the
defect/mcp-forms/npe-on-multifield
branch
from
cfea1f7 to
6b2b554
Compare
davidjgonzalez
approved these changes
Feb 22, 2024
davidjgonzalez
merged commit abbf3b2
into
Adobe-Consulting-Services:master
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3264 Make sure no null values are added to ValueMaps.
I had to add some new dependencies because JUnit 4 tests are not currently picked up by JUnit 5, but the JUnit 5 versions of some testing utilities were missing. You probably want to include the "junit-vintage" artifact to have the JUnit 5 engine run older tests.