Re-enable JUnit 4 and JUnit 3 unit tests #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When JUnit 5 support was added to the project, the "JUnit Vintage Engine" artifact wasn't added. Without this artifact, the JUnit 5 engine ignores any tests written for JUnit 4 or JUnit 3, i.e. the majority of the tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3273 +/- ##
=============================================
+ Coverage 1.78% 55.45% +53.67%
- Complexity 100 5506 +5406
=============================================
Files 721 721
Lines 29534 29534
Branches 3840 3840
=============================================
+ Hits 526 16378 +15852
+ Misses 28970 11630 -17340
- Partials 38 1526 +1488 ☔ View full report in Codecov by Sentry. |
kwin
requested changes
Feb 25, 2024
- Pull JUnit BOM instead of individual artifacts - Make JUnit engines dependencies of the surefire plugin
Pull only the necessary artifacts to the test classpath.
kwin
approved these changes
Feb 26, 2024
|
I have no idea why the Mac test failed or why the codeclimate check is stuck. Is there a way to redo the checks? Should I push a dummy commit? |
The first seems to be a race condition happening from time to time. Only happens on Mac CI, not related to your commit. No clue about the second one. Nothing to worry about though, this doesn't prevent the merge. I will wait till the end of the week before merging to give @davidjgonzalez to have a look as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was broken in #3233. With the addition of JUnit 5, the existing unit tests got ignored (note the sharp drop in overall coverage in the Codecov report). This PR should restore those old tests to full functionality.
Fixes #3270