Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed parameter for 'linkType' #361

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Changed parameter for 'linkType' #361

merged 3 commits into from
Nov 30, 2023

Conversation

shay-o
Copy link
Contributor

@shay-o shay-o commented Feb 13, 2023

The parameter for link type is 'pe'. This is not passed in the header.

Suggested a change the analytics parameter for link type.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The parameter for link type is 'pe'. This is not passed in the header.
@bretswalberg
Copy link
Contributor

Hold off on merging until I can look this over and discuss with @shay-o

@gigazelle
Copy link
Contributor

Tracked internally via AN-326503

@theswally
Copy link
Collaborator

lgtm

@gigazelle gigazelle merged commit 0f058bf into AdobeDocs:main Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants