Format improvements #415
Merged
Format improvements #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnwight
reviewed
Sep 6, 2023
|
|
||
| Additionally, using these endpoints requires your global company ID in each request. You can find your global company ID by using the [Discovery API](../discovery.md). | ||
| Additionally, using these endpoints requires your global company ID in each request. You can find your global company ID by using the [Discovery API](../discovery.md) |
There was a problem hiding this comment.
Period is actually needed here.
johnwight
reviewed
Sep 6, 2023
| @@ -454,7 +454,7 @@ The following table describes the GET classification template file request param | |||
| | Name | Required | Type | Description | | |||
| | --- | --- | --- | --- | | |||
| | `dataset_id` | required | string | Classification dataset ID | | |||
| | `format` | optional | string | Template format. The default is `tsv`. Includes the enums: `tsv`, and `csv`. | | |||
| | `format` | optional | string | Template format. The default is `tsv`. Possible values include `tsv` or `csv`. | | |||
There was a problem hiding this comment.
Will need articulation of data type enums.
johnwight
reviewed
Sep 6, 2023
| "state": "completed", | ||
| "recipients": [ | ||
| "[email protected]" | ||
| ] |
There was a problem hiding this comment.
The orphan single quote indeed suggests a JSON error. This is a direct value taken from Tony so I will double-check with him after merge to verify.
johnwight
reviewed
Sep 6, 2023
| } | ||
| } | ||
| ] | ||
| }' |
There was a problem hiding this comment.
See note on orphan single quote in other topic.
johnwight
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist