submission-review-updates #186
Conversation
| @@ -138,8 +138,27 @@ module.exports = { | |||
| ], | |||
| }, | |||
| { | |||
| title: "Submission and review", | |||
| title: "Integration submission and approval", | |||
There was a problem hiding this comment.
I would omit "Integration" as it seems redundant (and splits the text in two lines), what about "Submission and Approval" or "Submission & Approval"?
There was a problem hiding this comment.
I shall choose this: Submission and approval
| path: "/guides/review/", | ||
| pages: |
There was a problem hiding this comment.
I'm not 100% sure about this, so please correct me if I'm wrong, but I believe we usually have an explicit submenu entry for the page that opens when you click/expand the menu.
What I'm saying is that /review/index.md should also appear:
Submission and Approval
- Overview 👈 new, the index.md
- Submission guidelines
- Review test cases
- ...
There was a problem hiding this comment.
Let me check this.
| # Overview | ||
|
|
||
| This section provides a set of guidelines to help you in submitting your integrtion for review. | ||
|
|
||
| ## Submission guidelines |
There was a problem hiding this comment.
I would merge this into a single
# Submission guidelines
This section provides a set of guidelines to help you in submitting your integrtion for review.
You have to submit your app for approval in the [Adobe Developer Console](https://developer.adobe.com/console).
so that the main title matches the menu entry, you have the introductory sentence as a subtitle and the rest flows
In case, you might need to upgrade the following ## to # in the page.
| - https://github.com/nimithajalal | ||
| --- | ||
|
|
||
| # Rejection reasons |
There was a problem hiding this comment.
For consistency, I would pick as a title Handle rejections to match the submenu
| - https://github.com/nimithajalal | ||
| --- | ||
|
|
||
| # Overview |
There was a problem hiding this comment.
Same title/menu mismatch, I wouldn't start with Overview as a #
| Once your integration passes all stages of review, you will receive an approval notification, and your integration will be published or distributed as required. | ||
| If it was rejected, we will include the reasons for rejection along with any next steps. If you'd like to back and edit your submission, you can do so in the Developer Console. Checkout how to [handle rejections](./rejections.md) here. |
There was a problem hiding this comment.
For the future, it would be nice to have like a screenshot of an anonymized approval or rejection letter, just to give partners a sense of what to expect.
Totally minor/low-priority.
There was a problem hiding this comment.
Yeah, this can be arranged.
| # Overview | ||
|
|
||
| This guides helps you review the test cases before you submit your integration for review. | ||
|
|
||
| ## Review Test Cases |
There was a problem hiding this comment.
Doubts about starting with Overview again :-)
|
|
||
| ### Public Profile Content | ||
|
|
||
| - [ ] Name adheres to Adobe brand guidelines. |
There was a problem hiding this comment.
LOVE the checkboxes!!! Great idea!!
|
|
||
| - [ ] Name adheres to Adobe brand guidelines. | ||
| - **Example**: Ensure the public profile name is "ABCCompany" and not "ABC123". | ||
| - [ ] Logo does not include Adobe icons or dummy icons. |
There was a problem hiding this comment.
Oopsie, they turn out as disabled?!
I've investigated a bit, and apparently you can create checkboxes in markdown as [ ] and [x] but they aren't clickable (like, they're either unchecked or checked.
But I tried replacing them with <input type="checkbox"/> and this produces an actual, functional checkbox, so although tedious you might need to replace all [ ] with it.
There was a problem hiding this comment.
Interesting! So, what change would I need to make to have an actual checkbox?
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: