Develop data and schema patches - apply() method should return $this - required by PatchInterface docblock #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Nurgiel wants to merge 1 commit into AdobeDocs:main from Nurgiel:declarative-schema-patches-apply-method-should-return-this

Nurgiel commented May 15, 2024

Purpose of this pull request

PatchInterface requires apply() method to @return $this.

Code Sample provided on https://developer.adobe.com/commerce/php/development/components/declarative-schema/patches/ generates the following error when checked with phpstan:

Method Vendor\Module\Setup\Patch\Data\SomePatch::apply() should return $this, but return statement is missing.

Affected pages

https://developer.adobe.com/commerce/php/development/components/declarative-schema/patches/

Links to Magento Open Source code


          Develop data and schema patches - apply() should return

29288ca

Author

Nurgiel commented May 15, 2024

Example data patches from Magento Core that use return $this in apply() method:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet