Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v45 #80

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

v45 #80

wants to merge 32 commits into from

Conversation

arniebradfo
Copy link

@arniebradfo arniebradfo commented Nov 22, 2021

Contents of this Pull Request

This PR makes changes to

  • The typings in the types folder
  • Configuration files (tsconfig.json, jsconfig.json, .gitignore etc.)
  • The sample files (e.g., sample.js)
  • The README.md or other files containing documentation
  • Other

Purpose of this Pull Request

Update to XD v45 to make this useful again.

  • Updated the project structure and README.md for npm install consumption.
  • Tested in some of my xd plugin projects from the node_modules folder. It works with both .js an .ts
  • Its ready to deploy via npm publish.
    • Would be published to https://www.npmjs.com/package/@adobexd/typings
    • Could be added to DefinitelyTyped. I think it probably belongs there in the end, but I don't want to go through the hassle of publishing it through them.

Issues resolved by this Pull Request

  • Didn't make one

@pklaschka pklaschka self-requested a review November 25, 2021 17:52
@arniebradfo
Copy link
Author

Updated the Original PR comment to reflect changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant