Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing UBI Minimal Slim Images #339

Open
james-crowley opened this issue May 21, 2020 · 9 comments
Open

Missing UBI Minimal Slim Images #339

james-crowley opened this issue May 21, 2020 · 9 comments

Comments

@james-crowley
Copy link

With the script I am writing to help out #328, it identified a couple images that I expected to be up in DockerHub but are not.

{'adoptopenjdk/openjdk11-openj9:jdk11u-ubi-minimal-nightly-slim',
 'adoptopenjdk/openjdk11:jdk11u-ubi-minimal-nightly-slim',
 'adoptopenjdk/openjdk14-openj9:jdk14u-ubi-minimal-nightly-slim',
 'adoptopenjdk/openjdk14:jdk14u-ubi-minimal-nightly-slim',
 'adoptopenjdk/openjdk8-openj9:jdk8u-ubi-minimal-nightly-slim',
 'adoptopenjdk/openjdk8:jdk8u-ubi-minimal-nightly-slim'}

Looks like all the images are XXX-ubi-minimal-nightly-slim. @dinogun is there a reason why these are not being produced?

It seems like they should be built and publish on DockerHub.

@james-crowley
Copy link
Author

@smlambert FYI, these images came from the script I am working on.

@dinogun
Copy link
Collaborator

dinogun commented May 27, 2020

@james-crowley this is intentional, ubi-minimal did not have the tools needed by the slim-script (stip, binutils) and so the config file skips the slim build for ubi-minimal alone

Build: releases nightly
Type: full slim
Architectures: aarch64 x86_64 ppc64le s390x
Directory: 8/jdk/ubi

Build: releases nightly
Type: full
Architectures: aarch64 x86_64 ppc64le s390x
Directory: 8/jdk/ubi-minimal

@karianna
Copy link
Member

Should this be closed in that case?

@james-crowley
Copy link
Author

@dinogun Could we not have the script install these tools, use them to run said script, then remove them?

Also on the slim builds I saw that the slim script and other files are left inside the container? I feel like these should be removed if we are trying to give users an option to use where space is a premium?

Here was the folder with the slim scripts/left overs:

root@774f91365596:/usr/local/bin# ls
slim-java_bin_del.list  slim-java_jmod_del.list  slim-java_lib_del.list  slim-java_rtjar_del.list  slim-java_rtjar_keep.list  slim-java.sh

@srbala
Copy link
Contributor

srbala commented Apr 19, 2021

We can apply #478, with use of some custom script like slim-java-ubi-mimimal.sh, and remove files and folders with simple rm commands

@dinogun
Copy link
Collaborator

dinogun commented Apr 19, 2021

@srbala PR's welcome. You can add checks in slim-java.sh for ubi-minimal and accordingly make changes.

@srbala
Copy link
Contributor

srbala commented Apr 29, 2021

@dinogun ubi-minimal now seems to have the binutils package. I am able to add to the package install list. Please check https://gist.github.com/srbala/3cd4323652e406eaa998f2074c0d1183. I have hand edited for verification/testing.

Seems available at amd64/x86_64. Is it not available in other arch environments?

@srbala
Copy link
Contributor

srbala commented Apr 29, 2021

@dinogun
Copy link
Collaborator

dinogun commented Apr 29, 2021

@srbala If you want to test the scripts on all the arches, you can open an issue at the openjdk-infrastructure and request temporary Non-privileged access to machines of the arch that you are looking for. That should help you to test your changes before submitting a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants