Missing slim fixes to ubi, ubi-minimal, clefos #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bala Raman <[email protected]>
|
@karianna CI build failre related to alpine image, not related to changes in this pull request. Possibliy related to another issue of runtime library. |
dinogun
requested changes
May 10, 2021
Signed-off-by: Bala Raman <[email protected]>
|
@dinogun fixes ready for review |
dinogun
requested changes
May 18, 2021
Signed-off-by: Bala Raman <[email protected]>
Signed-off-by: Bala Raman <[email protected]>
|
@dinogun proposed changes completed, ready for review |
dinogun
reviewed
May 18, 2021
Signed-off-by: Bala Raman <[email protected]>
Signed-off-by: Bala Raman <[email protected]>
Signed-off-by: Bala Raman <[email protected]>
|
Removed slim images for JRE from the config as it is not currently supported, the tests are now passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dinogun Fix contains necessary changes requried resolve the slim package issues in ubi and others
This PR Does not contains the multi stage build, whichI indicated in discussion. Would like that to be add in this PR or send as another one. This PR is failrly straight forwrd, Multi stage build requires additional unit testing.