-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logger #64
base: main
Are you sure you want to change the base?
Add logger #64
Conversation
Codecov Report
@@ Coverage Diff @@
## main #64 +/- ##
===========================================
- Coverage 100.00% 95.91% -4.09%
===========================================
Files 17 19 +2
Lines 704 734 +30
===========================================
Hits 704 704
- Misses 0 30 +30
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arihantbansal you have not added the callbacks, the logger needs to have that as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks extensive and great! However, since this is in the debug mode it is not being tested, If you can add an example to show the behavior of all Loggers
@arihantbansal Can you try implementing your logger in the GAN Tutorial notebook so we can merge it ? |
@arihantbansal can you write the tests to complete the PR, Tensorboard and Tutorial test can be integrated in a different PR |
I'll try fix the callback logging and implement it in the tutorial by EOD. |
Remove logger from testing
This PR resolves Issue #23.