Skip to content

Commit

Permalink
Using different tags in template
Browse files Browse the repository at this point in the history
* using span instead of div for the component
* using real buttons for the actions
  • Loading branch information
thriqon committed Apr 29, 2015
1 parent 87dab01 commit ed8c9ab
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions addon/components/confirm-extension.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ import layout from '../templates/components/confirm-extension';
export default Ember.Component.extend({
layout: layout,

tagName: 'span',
classNames: ['ece-container'],

_setupClickHandler: function () {
var closer = _clickHandlerFor(this);
this.set('_closer', closer);
Expand Down
4 changes: 2 additions & 2 deletions addon/templates/components/confirm-extension.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<div class="ece-bubble">
<div class="ece-question">{{questionText}}</div>
<div class="ece-buttons">
<span class="ece-confirm" {{action 'confirm'}}>{{confirmText}}</span>
<span class="ece-decline" {{action 'decline'}}>{{declineText}}</span>
<button class="ece-confirm" {{action 'confirm'}}>{{confirmText}}</button>
<button class="ece-decline" {{action 'decline'}}>{{declineText}}</button>
</div>
</div>
{{/if}}

0 comments on commit ed8c9ab

Please sign in to comment.