-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide to contributing and a link in the readme #4
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request adds a 'Contributor's Guide' to the project and links it in the ReadMe file. The guide provides instructions for new contributors on how to fork the repository, keep their fork synchronized, create branches, write code, commit changes, push changes, create pull requests, and address feedback. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Lucas-lufa - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a table of contents to the contributor guide for easier navigation.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
git branch feature/my-feature | ||
|
||
``` | ||
- Then switch to the new branch you created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Missing space after 'created'.
Add a space after 'created' for better readability.
- Then switch to the new branch you created | |
- Then switch to the new branch you created |
|
||
## 6. Commit Your Work Locally with Descriptive Messages: | ||
- Commit changes with meaningful messages summarising your work. Reference the related issue in your commit messages. | ||
- First stage all your changed files for commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Add a comma after 'First'.
Adding a comma after 'First' improves clarity: 'First, stage all your changed files...'
- First stage all your changed files for commit | |
- First, stage all your changed files for commit |
I have used the contributing guide that we made for ocroo project.
Summary by Sourcery
Documentation: