-
Notifications
You must be signed in to change notification settings - Fork 140
Code generation: update services and models #1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3c5b40c
to
4c69b10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
As gemini-code-assist, I've analyzed this pull request, which appears to be an automated update originating from modifications to the OpenAPI specification files or templates, as indicated by the title and description. The changes primarily involve regenerating the Java client library code for the ACS webhooks and Balance Control APIs. The modifications seem focused on improving code accessibility by making several methods and classes public, along with minor formatting adjustments to Javadoc comments, indentation, and whitespace.
Highlights
- Automated Code Regeneration: The pull request contains code generated automatically based on updated OpenAPI specifications for the ACS webhooks and Balance Control APIs.
- Increased Code Accessibility: Several generated methods and internal helper classes have been updated with the
public
access modifier, making them accessible from outside their packages. - Code Formatting and Cleanup: Minor adjustments to Javadoc formatting, indentation, and whitespace have been applied across multiple generated files.
Changelog
Click here to see the changelog
- src/main/java/com/adyen/model/acswebhooks/AbstractOpenApiSchema.java
- Added blank lines and adjusted indentation.
- Added
public
modifier togetActualInstance()
,setActualInstance()
,getActualInstanceRecursively()
,getSchemas()
,getSchemaType()
,toString()
,toIndentedString()
,equals()
,hashCode()
, andisNullable()
methods.
- src/main/java/com/adyen/model/acswebhooks/AcsWebhooksHandler.java
- Adjusted Javadoc formatting and added blank lines.
- src/main/java/com/adyen/model/acswebhooks/Amount.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/AuthenticationDecision.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
- src/main/java/com/adyen/model/acswebhooks/AuthenticationInfo.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/acswebhooks/AuthenticationNotificationData.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/AuthenticationNotificationRequest.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/BalancePlatformNotificationResponse.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/ChallengeInfo.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/JSON.java
- Added
public
modifier togetMapper()
,setDateFormat()
,getClassForElement()
,isInstanceOf()
,registerDiscriminator()
,registerDescendants()
,getDefault()
, andsetDefault()
methods. - Added
public
modifier to the inner classClassDiscriminatorMapping
and its constructor and methods.
- Added
- src/main/java/com/adyen/model/acswebhooks/Purchase.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/PurchaseInfo.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/RelayedAuthenticationRequest.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/RelayedAuthenticationResponse.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/Resource.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/acswebhooks/ServiceError.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balancecontrol/AbstractOpenApiSchema.java
- Added blank lines and adjusted indentation.
- Added
public
modifier togetActualInstance()
,setActualInstance()
,getActualInstanceRecursively()
,getSchemas()
,getSchemaType()
,toString()
,toIndentedString()
,equals()
,hashCode()
, andisNullable()
methods.
- src/main/java/com/adyen/model/balancecontrol/Amount.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balancecontrol/BalanceTransferRequest.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balancecontrol/BalanceTransferResponse.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balancecontrol/JSON.java
- Added
public
modifier togetMapper()
,setDateFormat()
,getClassForElement()
,isInstanceOf()
,registerDiscriminator()
,registerDescendants()
,getDefault()
, andsetDefault()
methods. - Added
public
modifier to the inner classClassDiscriminatorMapping
and its constructor and methods.
- Added
- src/main/java/com/adyen/model/balanceplatform/AULocalAccountIdentification.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
- src/main/java/com/adyen/model/balanceplatform/AbstractOpenApiSchema.java
- Added blank lines and adjusted indentation.
- Added
public
modifier togetActualInstance()
,setActualInstance()
,getActualInstanceRecursively()
,getSchemas()
,getSchemaType()
,toString()
,toIndentedString()
,equals()
,hashCode()
, andisNullable()
methods.
- src/main/java/com/adyen/model/balanceplatform/AccountHolder.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/AccountHolderCapability.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/AccountHolderInfo.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/AccountHolderUpdateRequest.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/AccountSupportingEntityCapability.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/ActiveNetworkTokensRestriction.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/AdditionalBankIdentification.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/Address.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/AddressRequirement.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
- src/main/java/com/adyen/model/balanceplatform/Amount.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/AmountMinMaxRequirement.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
- src/main/java/com/adyen/model/balanceplatform/AmountNonZeroDecimalsRequirement.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
- src/main/java/com/adyen/model/balanceplatform/AssociationDelegatedAuthenticationData.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/AssociationFinaliseRequest.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/AssociationFinaliseResponse.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/AssociationInitiateRequest.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/AssociationInitiateResponse.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/Authentication.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/BRLocalAccountIdentification.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
- src/main/java/com/adyen/model/balanceplatform/Balance.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/BalanceAccount.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/BalanceAccountBase.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/BalanceAccountInfo.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/BalanceAccountUpdateRequest.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/BalancePlatform.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/BalanceSweepConfigurationsResponse.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/BalanceWebhookSetting.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/BalanceWebhookSettingInfo.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
- src/main/java/com/adyen/model/balanceplatform/BalanceWebhookSettingInfoUpdate.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
- src/main/java/com/adyen/model/balanceplatform/BankAccount.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/BankAccountAccountIdentification.java
- Added
public
modifier to the inner Serializer and Deserializer classes and their methods. - Added
public
modifier to constructors. - Added
public
modifier toget...()
methods. - Added
public
modifier tofromJson()
andtoJson()
methods.
- Added
- src/main/java/com/adyen/model/balanceplatform/BankAccountDetails.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
andhashCode()
methods.
- src/main/java/com/adyen/model/balanceplatform/BankAccountIdentificationTypeRequirement.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
- src/main/java/com/adyen/model/balanceplatform/BankAccountIdentificationValidationRequest.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor. - Adjusted indentation for
equals()
method.
- src/main/java/com/adyen/model/balanceplatform/BankAccountIdentificationValidationRequestAccountIdentification.java
- Added
public
modifier to the inner Serializer and Deserializer classes and their methods. - Added
public
modifier to constructors. - Added
public
modifier toget...()
methods. - Added
public
modifier tofromJson()
andtoJson()
methods.
- Added
- src/main/java/com/adyen/model/balanceplatform/BankAccountModel.java
- Adjusted Javadoc formatting and indentation.
- Added
public
modifier to the constructor.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
OpenAPI's might,
Code generation's might,
Java models bloom.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated update, likely from an OpenAPI generator, to update services and models. The changes primarily consist of:
- Re-indentation: Code across many files has been re-indented (e.g., from 2 spaces to 4 spaces).
- Javadoc Formatting: Numerous updates to Javadoc comments, mostly related to spacing, markdown list formatting, and minor textual adjustments.
- Import Reordering/Additions: Standard updates to import statements.
- Structural Changes for
oneOf
Schemas: Files likeBankAccountAccountIdentification.java
andBankAccountIdentificationValidationRequestAccountIdentification.java
show significant structural changes typical for generatedoneOf
schema handlers. These are complex but appear to follow standard generation patterns.
No logical changes to the core functionality of the models or handlers are immediately apparent from the diffs. The review assumes that the OpenAPI generator is functioning correctly and that these changes are intended outcomes of a spec or template update.
It's crucial to ensure that all automated tests pass after these generated changes to catch any unintended regressions or issues introduced by the generator.
Summary of Findings
- File Ending Newlines: Several generated files (e.g.,
AbstractOpenApiSchema.java
inacswebhooks
andbalancecontrol
,AcsWebhooksHandler.java
) end with\ No newline at end of file
. While a minor point, most style guides and linters prefer files to end with a single newline character. This was not commented on directly due to review severity settings. - Code Formatting: There are widespread code formatting changes, primarily re-indentation (e.g., from 2 spaces to 4 spaces) and Javadoc formatting. These are assumed to be intentional results of the code generation process. These were not commented on directly due to review severity settings.
- Generated
oneOf
Schema Handlers: Files likeBankAccountAccountIdentification.java
andBankAccountIdentificationValidationRequestAccountIdentification.java
have been significantly updated. This is characteristic of generated code foroneOf
OpenAPI schemas, involving complex deserialization logic to handle multiple possible types. The generated structure appears standard. Verification of correctness would depend on the OpenAPI specification and generator behavior.
Merge Readiness
This pull request consists of auto-generated code changes, primarily focused on formatting and updates to schema handlers. Assuming the OpenAPI specification and generator templates are correct and all CI checks and tests pass, these changes should be acceptable for merging. As an AI, I am unable to approve pull requests; this responsibility lies with other designated reviewers.
27957e4
to
2ca37d8
Compare
f11e95e
to
d7abee0
Compare
OpenAPI spec files or templates have been modified on 06-06-2025 by commit.