Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9098] Validate terms and agreements checkboxes for PayPal #2759

Merged
merged 6 commits into from
Nov 25, 2024
Merged

[ECP-9098] Validate terms and agreements checkboxes for PayPal #2759

merged 6 commits into from
Nov 25, 2024

Conversation

RokPopov
Copy link
Contributor

Description
When attempting to proceed with PayPal payment, if the Terms and Conditions checkbox is not selected, and the shopper tries to pay, the shopper experiences an infinite loading screen in the PayPal popup window. This PR addresses this issue by validating the terms and agreements first.

Tested scenarios

  • Successful payment with PayPal, card and redirect
  • Refreshing the screen during payment, to ensure there are no race conditions in the DOM loading

Fixes #2613

@RokPopov RokPopov requested a review from a team as a code owner September 30, 2024 09:05
@RokPopov RokPopov mentioned this pull request Sep 30, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

SushmitaThakur
SushmitaThakur previously approved these changes Nov 19, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khushboo-singhvi khushboo-singhvi merged commit 18e2968 into main Nov 25, 2024
13 of 14 checks passed
@khushboo-singhvi khushboo-singhvi deleted the ECP-9098 branch November 25, 2024 09:25
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Nov 22, 2024
Merged
@candemiralp candemiralp added the Fix Indicates a bug fix label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushboo-singhvi khushboo-singhvi khushboo-singhvi approved these changes

@candemiralp candemiralp candemiralp approved these changes

@SushmitaThakur SushmitaThakur Awaiting requested review from SushmitaThakur

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ECP-9098] PayPal not working when T&C's are not checked
4 participants
@RokPopov @khushboo-singhvi @candemiralp @SushmitaThakur