Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9489] Implement PHPStan and fix relevant issues #2843

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

[ECP-9489] Implement PHPStan and fix relevant issues #2843

wants to merge 64 commits into from

Conversation

candemiralp
Copy link
Member

@candemiralp candemiralp commented Jan 3, 2025 •
edited
Loading

Description

This PR implements automated PHPStan analysis as a part of the workflows. As Magento 2 has its own limitations, we have decided to use bitexpert/phpstan-magento extension to provide platform specific requirements.

Besides implementing PHPStan to the workflows, major issues having Level 0 severity have been fixed. Mainly,

  • Repositories have been used to load & save entities instead of the entity class' themselves.
  • Dynamic property declarations have been refactored.
  • Unit tests have been updated.

Tested scenarios

  • Test workflows
  • All payment flows including partial payments
  • All modification flows including partial payments

@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 31, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.9% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarQube Cloud

@candemiralp candemiralp marked this pull request as ready for review January 31, 2025 12:42
@candemiralp candemiralp requested a review from a team as a code owner January 31, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@candemiralp