-
Notifications
You must be signed in to change notification settings - Fork 82
Code generation: update services and models #1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the client library's services and models, reflecting recent modifications in the OpenAPI specification. The core changes involve the widespread introduction of new error response types for improved error handling, an expansion of recurring payment contract options, and general refinements to existing type definitions to maintain consistency and accuracy with the latest API contracts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated from an OpenAPI specification update, introduces changes across various services and models. The majority of modifications involve adding new error model imports, which is a positive step towards more robust error handling. Additionally, some models have been updated, and there are minor stylistic changes like quote standardization. I've identified one critical issue in src/typings/transferWebhooks/transferDataTracking.ts
where a mapping for polymorphic deserialization has been incorrectly removed, which could lead to runtime failures. Please see the detailed comment for the fix.
"estimation": "EstimationTrackingData", | ||
"internalReview": "InternalReviewTrackingData" | ||
}; | ||
static readonly mapping: {[index: string]: string} | undefined = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mapping
property is essential for the ObjectSerializer
to correctly deserialize polymorphic types based on the discriminator
. By setting it to undefined
, the deserialization of TransferDataTracking
will likely fail at runtime, as it won't be able to map discriminator values like "confirmation"
to their corresponding class types (ConfirmationTrackingData
). Please restore the mapping to ensure correct polymorphic deserialization.
static readonly mapping: {[index: string]: string} | undefined = {
"confirmation": "ConfirmationTrackingData",
"estimation": "EstimationTrackingData",
"internalReview": "InternalReviewTrackingData"
};
1d83712
to
ec60c1c
Compare
a1263d4
to
0cde1f1
Compare
a05a700
to
8ed13f1
Compare
OpenAPI spec files or templates have been modified on 10-10-2025 by commit.