Skip to content

Conversation

AdyenAutomationBot
Copy link
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Oct 1, 2025

OpenAPI spec files or templates have been modified on 10-10-2025 by commit.

@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner October 1, 2025 07:59
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the client library's services and models, reflecting recent modifications in the OpenAPI specification. The core changes involve the widespread introduction of new error response types for improved error handling, an expansion of recurring payment contract options, and general refinements to existing type definitions to maintain consistency and accuracy with the latest API contracts.

Highlights

  • Error Model Integration: New error models, specifically RestServiceError, ServiceError, and DefaultErrorResponseEntity, have been imported and integrated across numerous API service files in balancePlatform, binLookup, checkout, dataProtection, disputes, legalEntityManagement, management, payment, paymentsApp, payout, recurring, sessionAuthentication, storedValue, and transfers modules. This standardizes error handling and typing across the SDK.
  • Recurring API Enhancements: The RecurringApi has been updated to include new contract types (ONECLICK,RECURRING and EXTERNAL) in the Recurring.ContractEnum. Additionally, several methods (disable, listRecurringDetails, notifyShopper, scheduleAccountUpdater) have had their @deprecated JSDoc tags removed, indicating they are no longer considered deprecated.
  • Typing and Model Refinements: Several typing files, such as balanceWebhookSetting.ts and various sessionAuthentication resource files, have received new imports (SettingType, Target, ResourceType), suggesting updates to their underlying model definitions. The TransferDataTrackingClass in transferWebhooks also saw changes to its discriminator and mapping properties.
  • Code Style Consistency: Minor stylistic changes were applied to method signatures in accountHoldersApi.ts, transactionsApi.ts, and transfersApi.ts, where string literal types for parameters like formType, sortOrder, and category were updated from double quotes to single quotes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated from an OpenAPI specification update, introduces changes across various services and models. The majority of modifications involve adding new error model imports, which is a positive step towards more robust error handling. Additionally, some models have been updated, and there are minor stylistic changes like quote standardization. I've identified one critical issue in src/typings/transferWebhooks/transferDataTracking.ts where a mapping for polymorphic deserialization has been incorrectly removed, which could lead to runtime failures. Please see the detailed comment for the fix.

"estimation": "EstimationTrackingData",
"internalReview": "InternalReviewTrackingData"
};
static readonly mapping: {[index: string]: string} | undefined = undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The mapping property is essential for the ObjectSerializer to correctly deserialize polymorphic types based on the discriminator. By setting it to undefined, the deserialization of TransferDataTracking will likely fail at runtime, as it won't be able to map discriminator values like "confirmation" to their corresponding class types (ConfirmationTrackingData). Please restore the mapping to ensure correct polymorphic deserialization.

    static readonly mapping: {[index: string]: string} | undefined = {
        "confirmation": "ConfirmationTrackingData",
        "estimation": "EstimationTrackingData",
        "internalReview": "InternalReviewTrackingData"
    };

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 5 times, most recently from 1d83712 to ec60c1c Compare October 7, 2025 07:41
@AdyenAutomationBot AdyenAutomationBot requested a review from a team as a code owner October 7, 2025 07:41
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 7 times, most recently from a1263d4 to 0cde1f1 Compare October 10, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant