[SFI-464] GooglePay merchantId not being populated #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of being equal to live
zenit2001
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
zenit2001
requested review from
maassenbas,
amihajlovski and
shanikantsingh
as code owners
amihajlovski
approved these changes
Nov 21, 2023
shanikantsingh
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes proposed in this pull request:
This change checks if the front-end region includes live instead of being equal to live, since for different regions the second part of environment string can be different, while the first part stays
live.This PR solves the problem of setting the google pay configuration outside the EU region, as the merchant ID was not being passed correctly.
Fixed issue: SFI-464