BM express config #1197
Merged
BM express config #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amihajlovski
requested review from
dcardos,
shanikantsingh,
shubhamk67,
ShubhamVijaivargiya and
zenit2001
as code owners
|
zenit2001
approved these changes
Oct 29, 2024
amihajlovski
merged commit 066cd41
into
feature/SFI-397-apple-pay-on-pdp
20 of 22 checks passed
amihajlovski
added a commit
that referenced
this pull request
Nov 5, 2024
* feat: enabling/disabling apple pay express on pdp config (#1140) * Render applepay btn on PDP (#1145) * fix: removed err in catch * feat: override detail page * fix: unit tests * chore: move files * fix: tests * fix: render button on initial render of the product * feat: enabling/disabling apple pay express on pdp config (#1140) * Render applepay btn on PDP (#1145) * fix: removed err in catch * feat: override detail page * fix: unit tests * chore: move files * fix: tests * fix: render button on initial render of the product * chore: consolidate metadata attributes * chore: remove system attributes * Create temporary basket for express pdp (#1183) * feat(SFI-876): applepay express pdp * chore(SFI-876): unit tests * chore(SFI-876): unit tests * feat(SFI-876): create temporary basket for express pdp * fix(SFI-876): handle temporary basket creation failure * fix: adding csrf validation to applePayExpressCommon.js and linting * chore: linting --------- Co-authored-by: Zenit Shkreli <[email protected]> * applepay unit tests (#1193) * feat(SFI-876): applepay express pdp * chore(SFI-876): unit tests * chore(SFI-876): unit tests * feat(SFI-876): create temporary basket for express pdp * fix(SFI-876): handle temporary basket creation failure * fix: lint * chore: fix lint errors * fix: lint * chore: added tests for onshipping contact callback --------- Co-authored-by: shani <[email protected]> * BM express config (#1197) * feat: update the UI for enabling express buttons * feat: make title bolder * feat: adapt adyen settings page for modern UI * fix: removed duplicate key * fix: linting * fix: line items --------- Co-authored-by: Zenit Shkreli <[email protected]> Co-authored-by: Shani <[email protected]> Co-authored-by: shani <[email protected]>
amihajlovski
added a commit
that referenced
this pull request
Jan 20, 2025
* feat: enabling/disabling apple pay express on pdp config (#1140) * Render applepay btn on PDP (#1145) * fix: removed err in catch * feat: override detail page * fix: unit tests * chore: move files * fix: tests * fix: render button on initial render of the product * feat: enabling/disabling apple pay express on pdp config (#1140) * Render applepay btn on PDP (#1145) * fix: removed err in catch * feat: override detail page * fix: unit tests * chore: move files * fix: tests * fix: render button on initial render of the product * chore: consolidate metadata attributes * chore: remove system attributes * Create temporary basket for express pdp (#1183) * feat(SFI-876): applepay express pdp * chore(SFI-876): unit tests * chore(SFI-876): unit tests * feat(SFI-876): create temporary basket for express pdp * fix(SFI-876): handle temporary basket creation failure * fix: adding csrf validation to applePayExpressCommon.js and linting * chore: linting --------- Co-authored-by: Zenit Shkreli <[email protected]> * applepay unit tests (#1193) * feat(SFI-876): applepay express pdp * chore(SFI-876): unit tests * chore(SFI-876): unit tests * feat(SFI-876): create temporary basket for express pdp * fix(SFI-876): handle temporary basket creation failure * fix: lint * chore: fix lint errors * fix: lint * chore: added tests for onshipping contact callback --------- Co-authored-by: shani <[email protected]> * BM express config (#1197) * feat: update the UI for enabling express buttons * feat: make title bolder * feat: adapt adyen settings page for modern UI * fix: removed duplicate key * fix: linting * fix: line items * chore: tests conflicts * fix: version * chore: trigger e2e * chore: bump ubuntu ver * chore: upgrade playwright * fix: render generic comp * fix: tests --------- Co-authored-by: Zenit Shkreli <[email protected]> Co-authored-by: Shani <[email protected]> Co-authored-by: shani <[email protected]>
zenit2001
added a commit
that referenced
this pull request
Feb 4, 2025
* Reject giftcard (#1216) * include csrf token on get payment methods (#1217) * chore: include csrf * chore: validate instead of generating new one * Added support to card brands configured in merchant account in account page (#1223) * fix: setting 403 when notification fails (#1232) * Endpoint validations (#1234) * chore: endpoint validations * fix: tests * chore: remove logs * fix: unit tests * chore: endpoint validations * Revert "Added support to card brands configured in merchant account in account page (#1223)" This reverts commit 7f28013. * fix: conflicts * fix: paypal * chore: remove log * fix: lints * chore: cartridges * Added support to card brands configured in merchant account in account page (#1236) * feat: added support to card brands in adyen account page * chore: clicking consent button if visible --------- Co-authored-by: Zenit Shkreli <[email protected]> * Apple Pay on PDP (#1237) * feat: enabling/disabling apple pay express on pdp config (#1140) * Render applepay btn on PDP (#1145) * fix: removed err in catch * feat: override detail page * fix: unit tests * chore: move files * fix: tests * fix: render button on initial render of the product * feat: enabling/disabling apple pay express on pdp config (#1140) * Render applepay btn on PDP (#1145) * fix: removed err in catch * feat: override detail page * fix: unit tests * chore: move files * fix: tests * fix: render button on initial render of the product * chore: consolidate metadata attributes * chore: remove system attributes * Create temporary basket for express pdp (#1183) * feat(SFI-876): applepay express pdp * chore(SFI-876): unit tests * chore(SFI-876): unit tests * feat(SFI-876): create temporary basket for express pdp * fix(SFI-876): handle temporary basket creation failure * fix: adding csrf validation to applePayExpressCommon.js and linting * chore: linting --------- Co-authored-by: Zenit Shkreli <[email protected]> * applepay unit tests (#1193) * feat(SFI-876): applepay express pdp * chore(SFI-876): unit tests * chore(SFI-876): unit tests * feat(SFI-876): create temporary basket for express pdp * fix(SFI-876): handle temporary basket creation failure * fix: lint * chore: fix lint errors * fix: lint * chore: added tests for onshipping contact callback --------- Co-authored-by: shani <[email protected]> * BM express config (#1197) * feat: update the UI for enabling express buttons * feat: make title bolder * feat: adapt adyen settings page for modern UI * fix: removed duplicate key * fix: linting * fix: line items * chore: tests conflicts * fix: version * chore: trigger e2e * chore: bump ubuntu ver * chore: upgrade playwright * fix: render generic comp * fix: tests --------- Co-authored-by: Zenit Shkreli <[email protected]> Co-authored-by: Shani <[email protected]> Co-authored-by: shani <[email protected]> * fix: enabling atome (#1240) * Improve response body (#1239) * chore: remove basket id from response * chore: clean session attribute in case of error * chore: bump artifact version (#1244) * fix: moving pos scripts to a separate folder and moving hardcoded strings to constants --------- Co-authored-by: Aleksandar Mihajlovski <[email protected]> Co-authored-by: Shani <[email protected]> Co-authored-by: shani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Restructure the express toggles in adyen settings page
Easier configuration
Tested scenarios
Description of tested scenarios:
Fixed issue: SFI-984