Adding Google Pay on PDP #1198
Merged
Adding Google Pay on PDP #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zenit2001
requested review from
amihajlovski,
dcardos,
shanikantsingh,
shubhamk67 and
ShubhamVijaivargiya
as code owners
amihajlovski
approved these changes
Oct 24, 2024
zenit2001
merged commit 99ade84
into
feature/SFI-16-google-pay-express
18 checks passed
amihajlovski
added a commit
that referenced
this pull request
Feb 4, 2025
* feat: enabling/disabling apple pay express on pdp config (#1140) * Render applepay btn on PDP (#1145) * fix: removed err in catch * feat: override detail page * fix: unit tests * chore: move files * fix: tests * fix: render button on initial render of the product * chore: consolidate metadata attributes * chore: remove system attributes * Create temporary basket for express pdp (#1183) * feat(SFI-876): applepay express pdp * chore(SFI-876): unit tests * chore(SFI-876): unit tests * feat(SFI-876): create temporary basket for express pdp * fix(SFI-876): handle temporary basket creation failure * fix: adding csrf validation to applePayExpressCommon.js and linting * chore: linting --------- Co-authored-by: Zenit Shkreli <[email protected]> * Adding the google pay express enable/disable option and rendering it in cart and minicart (#1190) * feat: adding the google pay express enable/disable option for cart,minicart and pdp * feat: enabling google pay on cart/minicart * chore: linting * chore: css fix * chore: skipping klarna success test due to flakiness * chore: skipping ideal flaky test * chore: testing force:true if it solves flakiness * chore: reverting the force:true and skipping the other klarna,ideal flaky tests * feat: adding google pay on pdp (#1198) * feat: enabling payments call for google pay express * chore: added todo comment * fix: conflicts with the branch for sending only one payment methods call * On payment data changed (#1221) * feat: handle on payment data changed * feat: redirect to confirmation page * chore: remove log * fix: tests for google pau * fix: async promise lint error * Google Pay temp basket (#1222) * e2e tests google pay (#1224) * chore: remove basket id from response * fix: lint errors * Google Pay unit tests (#1241) * chore: unit tests for google pay express * chore: use blocked scoped variable * chore: test get transaction info * chore: unit tests for google pay express * chore: validate fn refactor * fix: unit tests * fix: google pay temp vs current basket amount * fix: e2e * fix: e2e * fix: add timeout * fix: revert timeout * fix: latest ver * chore: remove unneded code * chore: add timeout * fix: move timeout to paymentmethods page --------- Co-authored-by: Zenit Shkreli <[email protected]> Co-authored-by: Shani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the changes proposed in this pull request:
Enabling google pay express payments
It enabled google pay express on PDP
Tested scenarios
Description of tested scenarios:
Fixed issue: SFI-944