Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes payment method buttons to have radio role #1868

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

m1aw
Copy link
Contributor

@m1aw m1aw commented Nov 29, 2022

Summary

Change payment method items to have a radio role, this comes from the a11y audit.

Tested scenarios

From the accessibility audit:

  • Radio buttons in the same logical group are children of an element with role="radiogroup".
  • Each radio button element has role="radio".
  • When a radio button is checked, it must have aria-checked="true". Otherwise, it must have aria-checked="false".
  • The radio button must have an accessible name provided by internal text, aria-label, or aria-labelledby.
  • The radiogroup element must have an accessible name set with aria-labelledby or aria-label.

Fixed issue:
#1695

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Size Change: +166 B (0%)

Total Size: 946 kB

Filename Size Change
packages/lib/dist/adyen.js 250 kB +46 B (0%)
packages/lib/dist/cjs/index.js 215 kB +37 B (0%)
packages/lib/dist/es.modern/index.js 104 kB +44 B (0%)
packages/lib/dist/es/index.js 122 kB +39 B (0%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 5.76 kB
packages/lib/dist/es.modern/cs-CZ.js 5.21 kB
packages/lib/dist/es.modern/da-DK.js 4.71 kB
packages/lib/dist/es.modern/de-DE.js 5.11 kB
packages/lib/dist/es.modern/el-GR.js 6.46 kB
packages/lib/dist/es.modern/es-ES.js 4.81 kB
packages/lib/dist/es.modern/fi-FI.js 4.82 kB
packages/lib/dist/es.modern/fr-FR.js 4.94 kB
packages/lib/dist/es.modern/hr-HR.js 4.96 kB
packages/lib/dist/es.modern/hu-HU.js 5.12 kB
packages/lib/dist/es.modern/it-IT.js 4.79 kB
packages/lib/dist/es.modern/ja-JP.js 5.58 kB
packages/lib/dist/es.modern/ko-KR.js 5.19 kB
packages/lib/dist/es.modern/nl-NL.js 4.83 kB
packages/lib/dist/es.modern/no-NO.js 4.68 kB
packages/lib/dist/es.modern/pl-PL.js 5.23 kB
packages/lib/dist/es.modern/pt-BR.js 4.78 kB
packages/lib/dist/es.modern/pt-PT.js 4.92 kB
packages/lib/dist/es.modern/ro-RO.js 5.03 kB
packages/lib/dist/es.modern/ru-RU.js 6 kB
packages/lib/dist/es.modern/sk-SK.js 5.28 kB
packages/lib/dist/es.modern/sl-SI.js 4.85 kB
packages/lib/dist/es.modern/sv-SE.js 4.71 kB
packages/lib/dist/es.modern/zh-CN.js 5.04 kB
packages/lib/dist/es.modern/zh-TW.js 5.18 kB
packages/lib/dist/es/ar.js 5.76 kB
packages/lib/dist/es/cs-CZ.js 5.21 kB
packages/lib/dist/es/da-DK.js 4.71 kB
packages/lib/dist/es/de-DE.js 5.11 kB
packages/lib/dist/es/el-GR.js 6.46 kB
packages/lib/dist/es/es-ES.js 4.81 kB
packages/lib/dist/es/fi-FI.js 4.82 kB
packages/lib/dist/es/fr-FR.js 4.94 kB
packages/lib/dist/es/hr-HR.js 4.96 kB
packages/lib/dist/es/hu-HU.js 5.12 kB
packages/lib/dist/es/it-IT.js 4.79 kB
packages/lib/dist/es/ja-JP.js 5.58 kB
packages/lib/dist/es/ko-KR.js 5.19 kB
packages/lib/dist/es/nl-NL.js 4.83 kB
packages/lib/dist/es/no-NO.js 4.68 kB
packages/lib/dist/es/pl-PL.js 5.23 kB
packages/lib/dist/es/pt-BR.js 4.78 kB
packages/lib/dist/es/pt-PT.js 4.92 kB
packages/lib/dist/es/ro-RO.js 5.03 kB
packages/lib/dist/es/ru-RU.js 6 kB
packages/lib/dist/es/sk-SK.js 5.28 kB
packages/lib/dist/es/sl-SI.js 4.85 kB
packages/lib/dist/es/sv-SE.js 4.71 kB
packages/lib/dist/es/zh-CN.js 5.04 kB
packages/lib/dist/es/zh-TW.js 5.18 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants