Rework the removal of dynamic checks #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
dyn-checks-earlier
branch
3 times, most recently
from
6c6b114 to
fc096a0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Nadrieril
force-pushed
the
dyn-checks-earlier
branch
5 times, most recently
from
8cc86a7 to
2335415
Compare
sonmarcho
approved these changes
Apr 23, 2024
|
I opened #142 and checked aeneas locally. |
|
This may be breaking Eurydice (as #138 breaks Eurydice and is based on this). I haven't had time to investigate |
|
You can merge when you want. |
Nadrieril
force-pushed
the
dyn-checks-earlier
branch
2 times, most recently
from
aa48c03 to
346237a
Compare
|
This also breaks |
Nadrieril
force-pushed
the
dyn-checks-earlier
branch
2 times, most recently
from
91b195a to
21e74b1
Compare
Nadrieril
force-pushed
the
dyn-checks-earlier
branch
from
21e74b1 to
e952cff
Compare
Nadrieril
force-pushed
the
dyn-checks-earlier
branch
2 times, most recently
from
1848f74 to
2a73f37
Compare
Nadrieril
force-pushed
the
dyn-checks-earlier
branch
from
2a73f37 to
9f950c1
Compare
|
Alright, this is blocked until I can figure out how to implement the new |
This is important because they have different types and runtime semantics.
Nadrieril
force-pushed
the
dyn-checks-earlier
branch
from
9f950c1 to
036d0d3
Compare
This was referenced May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid interference with other passes, we do this one earlier on ullbc. We no longer remove overflow checks in const blocks because they're tricky to remove and will be evaluated anyway. I also had to distinguish checked from unchecked binary operations.
Fixes #125