Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batched disk functionality to route choice again, move coo_demand to matrix submodule, route choice bug fixes #554

Merged
merged 14 commits into from
Aug 9, 2024
Merged

Add batched disk functionality to route choice again, move coo_demand to matrix submodule, route choice bug fixes #554

merged 14 commits into from
Aug 9, 2024

Conversation

Jake-Moss
Copy link
Contributor

No description provided.

@Jake-Moss Jake-Moss changed the title Add batched disk functionality to route choice again, and style Add batched disk functionality to route choice again, move coo_demand to matrix submodule, route choice bug fixes Aug 2, 2024
pedrocamargo
pedrocamargo reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@pedrocamargo pedrocamargo left a comment •
edited by Jake-Moss
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing the following:

  • Adding the use of the ready-made class for sub-area analysis
  • Add the interior-interior demand to the subarea analysis

@Jake-Moss
Copy link
Contributor Author

Just missing the following:

* [x]   Adding the use of the ready-made class for sub-area analysis

* [x]  Add the interior-interior demand to the subarea analysis

@pedrocamargo Done and done

@pedrocamargo
Copy link
Contributor

Can either @janzill or @jamiecook do a quick review of the C++ here?

@pedrocamargo pedrocamargo merged commit 161a40c into AequilibraE:develop Aug 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrocamargo pedrocamargo pedrocamargo approved these changes

@jamiecook jamiecook Awaiting requested review from jamiecook

@janzill janzill Awaiting requested review from janzill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jake-Moss @pedrocamargo