Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload docs to merge_request_id on AWS #567

Conversation

r-akemii
Copy link
Collaborator

@r-akemii r-akemii commented Sep 3, 2024

@r-akemii r-akemii linked an issue Sep 3, 2024 that may be closed by this pull request
@r-akemii
Copy link
Collaborator Author

r-akemii commented Sep 3, 2024

@pedrocamargo I didn't manage to rename "dev" with the PR number due to an error stating that the folder with the PR number in S3 doesn't exist, but I managed to do something like "dev/PR_NUMBER", e.g.: https://aequilibrae.com/python/dev/567/index.html.

Do you think it works?

@r-akemii r-akemii marked this pull request as ready for review September 3, 2024 17:55
Copy link
Contributor

@pedrocamargo pedrocamargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did NOT WORK. The documentation is NOT there.

You probably want to rename the docs folder locally ${{github.event.number}} and upload the entire thing

pveigadecamargo and others added 2 commits September 4, 2024 22:55
@pedrocamargo pedrocamargo merged commit c1ba2d8 into develop Sep 4, 2024
15 checks passed
@pedrocamargo pedrocamargo deleted the renata/566-uploading-documentation-to-merge-request-id-on-aws branch September 4, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading documentation to merge request ID on AWS
2 participants