Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes deprecation warnings #572

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

r-akemii
Copy link
Collaborator

@r-akemii r-akemii commented Sep 11, 2024

In this PR we update the code to handle the deprecation changes in third-party libraries, particularly Shapely and Pandas.

The changes consist in:

  1. update of unary_union to union_all
  2. changed data type before filling NaN values in GMNS
  3. added context manager for graph_building when using fillna

Changes in bullets 2 and 3 are based on this answer on stackoverflow

@r-akemii r-akemii marked this pull request as ready for review September 11, 2024 19:50
@pedrocamargo pedrocamargo merged commit f9e196b into develop Sep 11, 2024
16 checks passed
@pedrocamargo pedrocamargo deleted the renata/unary_union-deprecation branch September 11, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants