Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy warnings #129

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix clippy warnings #129

merged 1 commit into from
Aug 13, 2024

Conversation

Tapped
Copy link
Contributor

@Tapped Tapped commented Aug 12, 2024

Currently main is failing when running cargo clippy --no-deps -- -D warnings. This PR fixes those errors.

@Tapped
Copy link
Contributor Author

Tapped commented Aug 12, 2024

@elpiel As noted in #128

@elpiel
Copy link
Member

elpiel commented Aug 12, 2024

@Tapped thank you very much for the pr.
Yes, testing against stable requires fixing some new lint when the CI starts using the new stable version.

Could you fix the last standing error as well?

@Tapped
Copy link
Contributor Author

Tapped commented Aug 13, 2024

@elpiel Right the repo is using nightly for clippy. I think the PR is good to go now.

@elpiel elpiel merged commit 1be3ad0 into AeroRust:main Aug 13, 2024
12 of 13 checks passed
@elpiel
Copy link
Member

elpiel commented Aug 13, 2024

Thank you for the PR!
Congratulations on your contribution 🚀🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants