Skip to content

Commit

Permalink
Bump coverallsapp/github-action from 1.1.3 to 2.2.3 (#104)
Browse files Browse the repository at this point in the history
* Bump coverallsapp/github-action from 1.1.3 to 2.2.3

Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 1.1.3 to 2.2.3.
- [Release notes](https://github.com/coverallsapp/github-action/releases)
- [Upgrade guide](https://github.com/coverallsapp/github-action/blob/main/UPGRADE.md)
- [Commits](coverallsapp/github-action@1.1.3...v2.2.3)

---
updated-dependencies:
- dependency-name: coverallsapp/github-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Apply fixes from StyleCI

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: StyleCI Bot <[email protected]>
  • Loading branch information
dependabot[bot] and StyleCIBot authored Nov 29, 2023
1 parent 4ba8a76 commit 865761c
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
if: matrix.php-version == '8.1'

- name: Coveralls
uses: coverallsapp/github-action@1.1.3
uses: coverallsapp/github-action@v2.2.3
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
path-to-lcov: build/lcov.info
Expand Down
1 change: 0 additions & 1 deletion examples/Connection/http_connect.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
$response = $epp_client->request($frame);

while ($response->success() && $response->code() !== 1300) { // 1300 = result successful, no more mesages

echo 'Epp Poll message ID: ';
echo $response->queueId();
echo "\n";
Expand Down
1 change: 1 addition & 0 deletions src/AfriCC/EPP/AbstractClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* @see ClientInterface
*
* As this class is abstract and relies on subclass implementation details it's untestable
*
* @codeCoverageIgnore
*/
abstract class AbstractClient implements ClientInterface
Expand Down
1 change: 1 addition & 0 deletions src/AfriCC/EPP/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* @see http://tools.ietf.org/html/rfc5734
*
* As this class deals directly with sockets it's untestable
*
* @codeCoverageIgnore
*/
class Client extends AbstractClient implements ClientInterface
Expand Down
1 change: 0 additions & 1 deletion src/AfriCC/EPP/DOM/DOMTools.php
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ public static function nodeToArray(

if (!$ignore_attributes && !in_array($each->localName, $ignoreAttributeKeys) && $each->hasAttributes()) {
foreach ($each->attributes as $attr) {

// single attribute with empty node, use the attr-value directly
if ($each->localName === 'status' || ($each->attributes->length === 1 && $each->nodeValue === '')) {
$current = $attr->nodeValue;
Expand Down
1 change: 1 addition & 0 deletions src/AfriCC/EPP/HTTPClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* @see http://tools.ietf.org/html/rfc5734
*
* As this class deals directly with cURL it's untestable
*
* @codeCoverageIgnore
*/
class HTTPClient extends AbstractClient implements ClientInterface
Expand Down

0 comments on commit 865761c

Please sign in to comment.