Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of SKIP options for JSON type #117

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

git-hulk
Copy link
Member

@git-hulk git-hulk commented Jan 7, 2025

<column_name> JSON(max_dynamic_paths=N, max_dynamic_types=M, some.path TypeName, SKIP path.to.skip, SKIP REGEXP 'paths_regexp')

Only support SKIP PATH and SKIP REGEXP in this PR, other options will be supported in further PR.

@git-hulk git-hulk force-pushed the feature/support-json-type-skip branch from 91eb9e2 to c905308 Compare January 7, 2025 13:25
@git-hulk git-hulk requested a review from Lance726 January 7, 2025 13:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12652509752

Details

  • 101 of 135 (74.81%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 60.52%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_table.go 0 1 0.0%
parser/ast_visitor.go 3 5 60.0%
parser/ast.go 46 61 75.41%
parser/parser_column.go 52 68 76.47%
Totals Coverage Status
Change from base Build 12540630182: 0.2%
Covered Lines: 6489
Relevant Lines: 10722

💛 - Coveralls

@git-hulk git-hulk merged commit 2757feb into AfterShip:master Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants