Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing DROP keyword in alter table drop clause #81

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix missing DROP keyword in alter table drop clause #81

merged 1 commit into from
Jul 16, 2024

Conversation

laojianzi
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9953813927

Details

  • 22 of 24 (91.67%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 58.073%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_alter.go 12 14 85.71%
Files with Coverage Reduction New Missed Lines %
parser/ast.go 4 53.76%
Totals Coverage Status
Change from base Build 9949491275: 0.007%
Covered Lines: 5906
Relevant Lines: 10170
💛 - Coveralls

@git-hulk git-hulk changed the title fix: parsing DROP DETACHED to drop statement for alter table Fix missing DROP keyword in alter table drop clause Jul 16, 2024
git-hulk
git-hulk reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@git-hulk git-hulk merged commit 55470ef into AfterShip:master Jul 16, 2024
1 check passed
@laojianzi laojianzi deleted the alter-table-drop-detached branch July 16, 2024 09:27
git-hulk pushed a commit to git-hulk/clickhouse-sql-parser that referenced this pull request Nov 29, 2024
@laojianzi @git-hulk
Fix missing DROP keyword in alter table drop clause (AfterShip#81)
eaff68f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laojianzi @coveralls @git-hulk