Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic while the query with order by Timestamp keyword #88

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix panic while the query with order by Timestamp keyword #88

merged 1 commit into from
Jul 24, 2024

Conversation

git-hulk
Copy link
Member

This closes #87

@git-hulk git-hulk requested a review from Lance726 July 24, 2024 09:55
@git-hulk git-hulk mentioned this pull request Jul 24, 2024
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10074502166

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.316%
Totals Coverage Status
Change from base Build 10037136454: 0.0%
Covered Lines: 5943
Relevant Lines: 10191
💛 - Coveralls

@git-hulk git-hulk merged commit 0c87106 into AfterShip:master Jul 24, 2024
1 check passed
git-hulk added a commit to git-hulk/clickhouse-sql-parser that referenced this pull request Nov 29, 2024
@git-hulk
Fix panic while the query with order by Timestamp keyword (AfterShip#88)
35dc4e2
@git-hulk git-hulk deleted the fix-order-by-panic branch November 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lance726 Lance726 Lance726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parser breaks on ORDER BY Timestamp
3 participants
@git-hulk @coveralls @Lance726