Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring core session management #486

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

Refactoring core session management #486

wants to merge 36 commits into from

Commits on Nov 12, 2024

  1. refactor(config.py): simplify Configuration class by using dataclass

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b7ddf3a View commit details
    Browse the repository at this point in the history

  2. feat(config.py): add graceful_shutdown_wait_time attribute to Configu… 

    …ration class for better control over shutdown behavior
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    70c229a View commit details
    Browse the repository at this point in the history

  3. refactor(session): restructure session management and threading

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d70d6fe View commit details
    Browse the repository at this point in the history

  4. chore(pyproject): add "-s" to pytest addopts 

    Fixes PDB within pytest
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e1c9b91 View commit details
    Browse the repository at this point in the history

  5. fixup! refactor(session): restructure session management and threading

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    28709a0 View commit details
    Browse the repository at this point in the history

  6. Remove EventsCounter 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    e991472 View commit details
    Browse the repository at this point in the history

  7. feat(session): add debug logging for session events and state

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    eb15582 View commit details
    Browse the repository at this point in the history

  8. fix construction (use dataclass); adjust initialization order 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    85b18dd View commit details
    Browse the repository at this point in the history

  9. refactor(session): change SessionStruct to SessionDict

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7078637 View commit details
    Browse the repository at this point in the history

  10. privatize locks attr 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    3831e1e View commit details
    Browse the repository at this point in the history

  11. clean 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    eaad74b View commit details
    Browse the repository at this point in the history

  12. Assign config as object-level member 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d36440f View commit details
    Browse the repository at this point in the history

  13. streamline setting of jwt in SessionApi - reflect Session's 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ff399f9 View commit details
    Browse the repository at this point in the history

  14. Correct SessionApi initialization 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f5d53ea View commit details
    Browse the repository at this point in the history

  15. refactor(session): update batch method to use api.batch()

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2044f73 View commit details
    Browse the repository at this point in the history

  16. style(session.py): format code and import statements

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    df3fd74 View commit details
    Browse the repository at this point in the history

  17. Fix event_type accessor 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a350785 View commit details
    Browse the repository at this point in the history

  18. Remove exc suppression 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    009eddd View commit details
    Browse the repository at this point in the history

  19. improve SessionDict init 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b43a45f View commit details
    Browse the repository at this point in the history

  20. fix Sesssion self access 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4218243 View commit details
    Browse the repository at this point in the history

  21. misc queue fixes 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    066715d View commit details
    Browse the repository at this point in the history

  22. clean imports 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    266347e View commit details
    Browse the repository at this point in the history

  23. feat(session): add active property to Session class

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1c71408 View commit details
    Browse the repository at this point in the history

  24. refactor(session): streamline type hints and properties

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    fed537b View commit details
    Browse the repository at this point in the history

  25. refactor(session): streamline exception handling logic

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    47a934f View commit details
    Browse the repository at this point in the history

  26. make the threads stop properly when requested and prevent the infinit… 

    …e loop

Added proper error handling in both thread classesModified the
EventPublisherThread to check stopping condition more frequentlyAdded
condition to publish events when stoppingImproved thread shutdown
logicAdded shorter timeout in ChangesObserverThread to check stopping
flag more frequentlyAdded proper cleanup in stop() methods

Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    8838b52 View commit details
    Browse the repository at this point in the history

  27. misc 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c91f52b View commit details
    Browse the repository at this point in the history

  28. refactor(session): remove deprecated active property and clean up

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6bdf714 View commit details
    Browse the repository at this point in the history

  29. improve logging 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7aca074 View commit details
    Browse the repository at this point in the history

  30. feat(session): add active property for backward compatibility

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    00c2319 View commit details
    Browse the repository at this point in the history

  31. refactor(session): clean up end_session and stop_session logic

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1f00391 View commit details
    Browse the repository at this point in the history

  32. weakset, reference tracking, etc

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ce45bc9 View commit details
    Browse the repository at this point in the history

  33. SessionsCollection: add custom iterator for sorted sessions

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    561dd2a View commit details
    Browse the repository at this point in the history

  34. introduce SessionsCollection

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c73e93e View commit details
    Browse the repository at this point in the history

  35. refactor(client): convert active_sessions to a list

    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a7e527f View commit details
    Browse the repository at this point in the history

  36. fixes test_session.TestSingleSessions 

    Signed-off-by: Teo <[email protected]>
    @teocns
    teocns committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bfca31a View commit details
    Browse the repository at this point in the history