Simplify field key assertions using set comparison #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

denini08 wants to merge 1 commit into Aggify:main from denini08:list-set

denini08 commented May 17, 2025

This PR updates some assertions in test_aggify.py to:

Compare directly with a set instead of converting keys to a list for faster lookups O(1).
Make the tests simpler and cleaner.
Keep the same test logic and behavior.


          update lookup to use sets

19415e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet