Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump administrate from 0.12.0 to 0.13.0 #1396

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps administrate from 0.12.0 to 0.13.0. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

Sort order SQL injection via direction parameter in administrate In Administrate (rubygem) before version 0.13.0, when sorting by attributes on a dashboard, the direction parameter was not validated before being interpolated into the SQL query.

This could present a SQL injection if the attacker were able to modify the direction parameter and bypass ActiveRecord SQL protections.

Whilst this does have a high-impact, to exploit this you need access to the Administrate dashboards, which should generally be behind authentication.

Patched versions: >= 0.13.0 Unaffected versions: none

Sourced from The GitHub Security Advisory Database.

High severity vulnerability that affects administrate In Administrate (rubygem) before version 0.13.0, when sorting by attributes on a dashboard, the direction parameter was not validated before being interpolated into the SQL query. This could present a SQL injection if the attacker were able to modify the direction parameter and bypass ActiveRecord SQL protections.

Whilst this does have a high-impact, to exploit this you need access to the Administrate dashboards, which we would expect to be behind authentication.

This is patched in wersion 0.13.0.

Affected versions: < 0.13.0

Release notes

Sourced from administrate's releases.

0.13.0

NOTE: This release contains the fix for CVE-2020-5257, which fixes a potential SQL injection on dashboard sorting.

  • [SECURITY] Fix Sort order SQL injection.
  • [BUGFIX] #1561 Fix very narrow nested fields.
  • [BUGFIX] #1565 Fix unterminated single quote.
  • [UI] #1537 Provide tags for doc pages.
  • [BUGFIX] #1552 Use the correct foreign key when sorting belongs_to associations.
  • [FEATURE] #1551 More readable warnings.
  • [FEATURE] #1512 Avoid confusion with class methods and protected/private modifiers.
  • [FEATURE] #1513 Accessible from templates; avoids having to create new field types.
  • [UI] #1536 Declare doctype, language and charset.
  • [DOC] #1540 Add new Date field to docs.
  • [FEATURE] #1530 Include Date Field.
  • [BUGFIX] #1522 Align label and data on show page.
  • [FEATURE] #1521 Expose required fields on form.
  • [DOC] #1531 Remove project level rubocop.yml.
  • [DOC] #1534 Move documentation of how to disable some actions on controller.
  • [UI] #1524 Hide resources without index in the navigation.
  • [DOC] #1523 Update screenshot.
  • [UI] #1376 Add a "back" link to the navigation.
  • [DOC] #1187 Update comment with new namespace.
  • [DOC] #1514 Rewrite the contributing guide.
  • [BUGFIX] #1495 Attempt to fix random CI failures.
  • [BUGFIX] #1507 Remove query from link, to avoid triggering banned params.
  • [DOC] #1479 Document controller APIs.
  • [COMPAT] #1475 Allows running specs individually.
  • [UI] #1484 Double-click to select attribute text.
  • [DOC] Configure GitHub Sponsors.
  • [COMPAT] #1457 Fix PhantomJS test behaviour on Linux.
  • [BUGFIX] #920 Remove NameError rescue in page base.
  • [BUGFIX] #1447 Don't pass raw SQL when changing sort order.
  • [FEATURE] #1452 Support Sprockets 4.
  • [DOC] #1426 Add issue templates.
Changelog

Sourced from administrate's changelog.

0.13.0 (March 13, 2020)

NOTE: This release contains the fix for CVE-2020-5257, which fixes a potential SQL injection on dashboard sorting.

  • [SECURITY] Fix Sort order SQL injection.
  • [BUGFIX] #1561 Fix very narrow nested fields.
  • [BUGFIX] #1565 Fix unterminated single quote.
  • [UI] #1537 Provide tags for doc pages.
  • [BUGFIX] #1552 Use the correct foreign key when sorting belongs_to associations.
  • [FEATURE] #1551 More readable warnings.
  • [FEATURE] #1512 Avoid confusion with class methods and protected/private modifiers.
  • [FEATURE] #1513 Accessible from templates; avoids having to create new field types.
  • [UI] #1536 Declare doctype, language and charset.
  • [DOC] #1540 Add new Date field to docs.
  • [FEATURE] #1530 Include Date Field.
  • [BUGFIX] #1522 Align label and data on show page.
  • [FEATURE] #1521 Expose required fields on form.
  • [DOC] #1531 Remove project level rubocop.yml.
  • [DOC] #1534 Move documentation of how to disable some actions on controller.
  • [UI] #1524 Hide resources without index in the navigation.
  • [DOC] #1523 Update screenshot.
  • [UI] #1376 Add a "back" link to the navigation.
  • [DOC] #1187 Update comment with new namespace.
  • [DOC] #1514 Rewrite the contributing guide.
  • [BUGFIX] #1495 Attempt to fix random CI failures.
  • [BUGFIX] #1507 Remove query from link, to avoid triggering banned params.
  • [DOC] #1479 Document controller APIs.
  • [COMPAT] #1475 Allows running specs individually.
  • [UI] #1484 Double-click to select attribute text.
  • [DOC] Configure GitHub Sponsors.
  • [COMPAT] #1457 Fix PhantomJS test behaviour on Linux.
  • [BUGFIX] #920 Remove NameError rescue in page base.
  • [BUGFIX] #1447 Don't pass raw SQL when changing sort order.
  • [FEATURE] #1452 Support Sprockets 4.
  • [DOC] #1426 Add issue templates.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [administrate](https://github.com/thoughtbot/administrate) from 0.12.0 to 0.13.0. **This update includes security fixes.**
- [Release notes](https://github.com/thoughtbot/administrate/releases)
- [Changelog](https://github.com/thoughtbot/administrate/blob/master/CHANGELOG.md)
- [Commits](thoughtbot/administrate@v0.12.0...v0.13.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@dependabot-preview dependabot-preview bot added dependencies security Pull requests that address a security vulnerability labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants