Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed infra defaults for deploy commands #1917

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fixed infra defaults for deploy commands #1917

merged 1 commit into from
Jan 22, 2024

Conversation

kessler-frost
Copy link
Member

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@kessler-frost kessler-frost marked this pull request as ready for review January 22, 2024 13:25
@kessler-frost kessler-frost requested a review from a team as a code owner January 22, 2024 13:25
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5700337) 84.49% compared to head (adc84ff) 85.06%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1917      +/-   ##
===========================================
+ Coverage    84.49%   85.06%   +0.57%     
===========================================
  Files          295      181     -114     
  Lines        14472    11255    -3217     
  Branches       195        0     -195     
===========================================
- Hits         12228     9574    -2654     
+ Misses        2110     1681     -429     
+ Partials       134        0     -134     
Flag Coverage Δ *Carryforward flag
Dispatcher 92.50% <ø> (+0.17%) ⬆️ Carriedforward from 5700337
Functional_Tests ?
SDK 79.46% <42.85%> (-0.06%) ⬇️
UI_Backend ?
UI_Frontend ?

*This pull request uses carry forward flags. Click here to find out more.

@kessler-frost
Copy link
Member Author

Tests are being added for these files in a separate PR: #1893. Thus the diff coverage should not be a blocker.

@cjao cjao merged commit 2f46195 into develop Jan 22, 2024
13 of 14 checks passed
@cjao cjao deleted the infra-defaults-fix branch January 22, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants